Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38507

pull request builder plugin triggers builds on new commit (without keyword)

    XMLWordPrintable

Details

    Description

      What we observe is this behaviour

      • PR created.
      • Comment (runbuild) added to PR and that triggers the build
      • Build fails (for whatever reason)
      • Developer pushes more commits into PR branch a few days later
      • stash plugin triggers the build immediately. Comment was NOT updated with runbuild keyword

      This appears to be a bug, because, Plugin seems to get confused (or it is intentional?)
      It should not trigger builds on new commits, only on keyword in PR comment.

      Attachments

        Activity

          We want Plugin to only check last comment for trigger keywords. Push of the commit by itself should not trigger the build.

          sleonovich Sergey Leonovich added a comment - We want Plugin to only check last comment for trigger keywords. Push of the commit by itself should not trigger the build.

          Also, it appears that Jenkins setup for the plugin does not support regular expressions for "CI Build Phrases"
          We only want to trigger the build on ^runbuild$ - complete word.
          Not being able to do that can also trigger false build execution if developer just mentions "runbuild" in the comment section without intention to actually run the build.

          sleonovich Sergey Leonovich added a comment - Also, it appears that Jenkins setup for the plugin does not support regular expressions for "CI Build Phrases" We only want to trigger the build on ^runbuild$ - complete word. Not being able to do that can also trigger false build execution if developer just mentions "runbuild" in the comment section without intention to actually run the build.

          Any update on this please

          sleonovich Sergey Leonovich added a comment - Any update on this please

          We also noticed that occasionally Pull request plugin seems to trigger multiple builds on the same PR/Commit with no apparent reason.
          The first build that gets into Jenkins queue succeeds, the others fail, and it generate multiple notifications. I am attaching screen shots as examples:

          sleonovich Sergey Leonovich added a comment - We also noticed that occasionally Pull request plugin seems to trigger multiple builds on the same PR/Commit with no apparent reason. The first build that gets into Jenkins queue succeeds, the others fail, and it generate multiple notifications. I am attaching screen shots as examples:

          Any update on this?

          sleonovich Sergey Leonovich added a comment - Any update on this?

          This issue has been automatically closed because of inactivity. Please reopen it if you think it's still valid

          jbochenski Jakub Bochenski added a comment - This issue has been automatically closed because of inactivity. Please reopen it if you think it's still valid

          People

            nemccarthy nathan m
            sleonovich Sergey Leonovich
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: