Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38541

SocketTimeoutException should not be fatal in BIONetworkLayer

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: remoting
    • Labels:
      None
    • Similar Issues:

      Attachments

        Activity

        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Stephen Connolly
        Path:
        src/main/java/hudson/remoting/Launcher.java
        src/main/java/hudson/remoting/jnlp/Main.java
        http://jenkins-ci.org/commit/remoting/2c8824a6f2a17d66715adf626d17a44faf4558ec
        Log:
        JENKINS-38541 Tweak help text for CLI -noKeepAlive option

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/remoting/Launcher.java src/main/java/hudson/remoting/jnlp/Main.java http://jenkins-ci.org/commit/remoting/2c8824a6f2a17d66715adf626d17a44faf4558ec Log: JENKINS-38541 Tweak help text for CLI -noKeepAlive option
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Stephen Connolly
        Path:
        src/main/java/org/jenkinsci/remoting/protocol/impl/BIONetworkLayer.java
        http://jenkins-ci.org/commit/remoting/e53736088bfcf6af23b058e370e5c5a53ccc62ba
        Log:
        [FIXED JENKINS-38541] SocketTimeoutException should not be fatal for BIONetworkLayer (#111)

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/remoting/protocol/impl/BIONetworkLayer.java http://jenkins-ci.org/commit/remoting/e53736088bfcf6af23b058e370e5c5a53ccc62ba Log: [FIXED JENKINS-38541] SocketTimeoutException should not be fatal for BIONetworkLayer (#111)
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Stephen Connolly
        Path:
        src/main/java/hudson/remoting/Engine.java
        src/main/java/hudson/remoting/Launcher.java
        src/main/java/hudson/remoting/jnlp/Main.java
        http://jenkins-ci.org/commit/remoting/e3f352697b745c8b2d98dd0beac2313920581720
        Log:
        [FIXED JENKINS-38539] Turn on SO_KEEPALIVE and provide CLI option to turn it off again (#110)

        • [FIXED JENKINS-38539] Turn on SO_KEEPALIVE and provide CLI option to turn it off again
        • Most OSes have a default SO_KEEPALIVE of 2 hours, and perform keepalive without generating any significant traffic
          The master side of the connection already has SO_KEEPALIVE enabled, this just allows both OSes to keep their own
          guidance and therefore assist when tuning the agent side is more appropriate than changing the kernel parameters on
          the master side (as the master is handling the HTTP requests of users)
        • Would probably be perfectly safe to not even expose the -noKeepAlive option as the SO_KEEPALIVE should be invisible
          But there may be users that have the requirement to disable, so safer to provide the option
        • Change was developed against the stable-2.x branch
        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/remoting/Engine.java src/main/java/hudson/remoting/Launcher.java src/main/java/hudson/remoting/jnlp/Main.java http://jenkins-ci.org/commit/remoting/e3f352697b745c8b2d98dd0beac2313920581720 Log: [FIXED JENKINS-38539] Turn on SO_KEEPALIVE and provide CLI option to turn it off again (#110) [FIXED JENKINS-38539] Turn on SO_KEEPALIVE and provide CLI option to turn it off again Most OSes have a default SO_KEEPALIVE of 2 hours, and perform keepalive without generating any significant traffic The master side of the connection already has SO_KEEPALIVE enabled, this just allows both OSes to keep their own guidance and therefore assist when tuning the agent side is more appropriate than changing the kernel parameters on the master side (as the master is handling the HTTP requests of users) Would probably be perfectly safe to not even expose the -noKeepAlive option as the SO_KEEPALIVE should be invisible But there may be users that have the requirement to disable, so safer to provide the option Change was developed against the stable-2.x branch JENKINS-38541 Tweak help text for CLI -noKeepAlive option

          People

          Assignee:
          stephenconnolly Stephen Connolly
          Reporter:
          stephenconnolly Stephen Connolly
          Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

            Dates

            Created:
            Updated:
            Resolved: