Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38579

"All" view hyperlinks get localized, conflict with BlueOcean

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Critical Critical
    • blueocean-plugin
    • jenkins-2.7.4
      blueocean - Built at 27th September 2016 03:05 AM (no branch) 57f7758

      I have started a new Jenkins instance when my browser had a Russian locale enabled by default. In such case AllView has a name "Все" instead of "All". It impacts hyperlinks within the entire UI (e.g. "http://localhost:8080/jenkins/view/Все/newJob").

      After the installation f my instance I installed Locale plugin and configured it to use the en-US locale. When I try to create a new job in BlueOcean, it redirects me to http://localhost:8080/jenkins/view/All/newJob. For this link I get a 404 error.

      See the attached screenshots.

        1. AllView.png
          AllView.png
          189 kB
        2. Error.png
          Error.png
          31 kB
        3. Locale plugin.png
          Locale plugin.png
          33 kB

          [JENKINS-38579] "All" view hyperlinks get localized, conflict with BlueOcean

          Daniel Beck added a comment -

          Not a core issue. If the 'All' name is hardcoded, that's just plain wrong as users can change the default view, and even remove the 'All; view.

          https://wiki.jenkins-ci.org/display/JENKINS/Editing+or+Replacing+the+All+View

          Daniel Beck added a comment - Not a core issue. If the 'All' name is hardcoded, that's just plain wrong as users can change the default view, and even remove the 'All; view. https://wiki.jenkins-ci.org/display/JENKINS/Editing+or+Replacing+the+All+View

          Jenkins has created the AllView with a name in Russian on the first startup. I have not changed anything on my own. I think Jenkins core somehow takes Display name instead of the name.

          Kseniia Nenasheva added a comment - Jenkins has created the AllView with a name in Russian on the first startup. I have not changed anything on my own. I think Jenkins core somehow takes Display name instead of the name.

          Daniel Beck added a comment -

          Daniel Beck added a comment - Blue Ocean hardcoding things that should not be hardocded does not make this a core bug

          Daniel Beck added a comment -

          As I wrote above, users can change which view is the default, and even delete the 'All' (or Bce) view, so even if we moved to localizing separate display names, it would still be a bug in Blue Ocean and have the same fix – Jenkins.getInstance().getPrimaryView().getName()

          Daniel Beck added a comment - As I wrote above, users can change which view is the default, and even delete the 'All' (or Bce) view, so even if we moved to localizing separate display names, it would still be a bug in Blue Ocean and have the same fix – Jenkins.getInstance().getPrimaryView().getName()

          Yes, I agree that this is a bug in Blue Ocean.
          But, IMHO, the core should not create a view using the locale. Can I create new ticket for only core (without Blue Ocean) ?

          Kseniia Nenasheva added a comment - Yes, I agree that this is a bug in Blue Ocean. But, IMHO, the core should not create a view using the locale. Can I create new ticket for only core (without Blue Ocean) ?

          Daniel Beck added a comment -

          Sure, file away.

          Daniel Beck added a comment - Sure, file away.

          danielbeck, thanks!
          Done. Ticket JENKINS-38606

          Kseniia Nenasheva added a comment - danielbeck , thanks! Done. Ticket JENKINS-38606

          Michael Neale added a comment -

          Thanks ks_nenasheva - I have linked this as a dupe of another ticket.
          This link should not be hard coded in blue ocean (there is some work under way for i18n) but also, this link shouldn't need to exist in the header once the create-pipeline features are there.

          so if it is ok, I will close this (and just link to it for the details).

          Michael Neale added a comment - Thanks ks_nenasheva - I have linked this as a dupe of another ticket. This link should not be hard coded in blue ocean (there is some work under way for i18n) but also, this link shouldn't need to exist in the header once the create-pipeline features are there. so if it is ok, I will close this (and just link to it for the details).

            Unassigned Unassigned
            ks_nenasheva Kseniia Nenasheva
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: