• Type: Bug
• Resolution: Fixed
• Priority: Major
• Component/s: maven-metadata-plugin
• Labels:

  • parameter
  • pipeline
  • plugin

[JENKINS-38619] Maven metadata plugin does not work with jenkins pipeline

Collapse comment: Torsten Reinhard added a comment - 2017-01-12 14:18

Torsten Reinhard added a comment - 2017-01-12 14:18

Workaround to access the properties anyway:

...
// currently not possible, so workaround used:
// String version = params.COMPONENT_VERSION
String version = currentBuild.rawBuild.getAction(hudson.model.ParametersAction).getParameter("COMPONENT").version
...

Expand comment: Torsten Reinhard added a comment - 2017-01-12 14:18

Torsten Reinhard added a comment - 2017-01-12 14:18 Workaround to access the properties anyway: ... // currently not possible, so workaround used: // String version = params.COMPONENT_VERSION String version = currentBuild.rawBuild.getAction(hudson.model.ParametersAction).getParameter( "COMPONENT" ).version ...

Collapse comment: Torsten Reinhard added a comment - 2017-02-08 11:06

Torsten Reinhard added a comment - 2017-02-08 11:06

improvement to get it working, even if "COMPONENT_VERSION" will be passed as String parameter from an upstream project:

String getVersion( String parameterName ) {
    def action = currentBuild.rawBuild.getAction(hudson.model.ParametersAction)

    // try to get the value directly if passed as String from an upstream job    
    StringParameterValue passed = (StringParameterValue)action.getParameter("${parameterName}_VERSION")
    if( passed != null ) {
        return passed.getValue()        
    }
    
    // get the version property directly from Maven MetaDataPlugin
    return action.getParameter(parameterName).version
}

Expand comment: Torsten Reinhard added a comment - 2017-02-08 11:06

Torsten Reinhard added a comment - 2017-02-08 11:06 improvement to get it working, even if "COMPONENT_VERSION" will be passed as String parameter from an upstream project: String getVersion( String parameterName ) { def action = currentBuild.rawBuild.getAction(hudson.model.ParametersAction) // try to get the value directly if passed as String from an upstream job StringParameterValue passed = (StringParameterValue)action.getParameter( "${parameterName}_VERSION" ) if ( passed != null ) { return passed.getValue() } // get the version property directly from Maven MetaDataPlugin return action.getParameter(parameterName).version }

Collapse comment: Benjamin BONNET added a comment - 2017-12-07 14:58

Benjamin BONNET added a comment - 2017-12-07 14:58

Hi,

I submitted a PR to fix that bug : see https://github.com/jenkinsci/maven-metadata-plugin/pull/13 

P.S. : torstenreinhard's work-around did not work for me (action was null).

Expand comment: Benjamin BONNET added a comment - 2017-12-07 14:58

Benjamin BONNET added a comment - 2017-12-07 14:58 Hi, I submitted a PR to fix that bug : see https://github.com/jenkinsci/maven-metadata-plugin/pull/13   P.S. :  torstenreinhard 's work-around did not work for me (action was null).

Collapse comment: SCM/JIRA link daemon added a comment - 2018-01-10 09:12

SCM/JIRA link daemon added a comment - 2018-01-10 09:12

Code changed in jenkins
User: Benjamin BONNET
Path:
src/main/lombok/eu/markov/jenkins/plugin/mvnmeta/MavenMetadataParameterValue.java
http://jenkins-ci.org/commit/maven-metadata-plugin/ac3b6f65c4ff7d9a5d5acf054fa1e84ddf3487bd
Log:
Return param value to pipeline

see https://issues.jenkins-ci.org/browse/JENKINS-38619

Expand comment: SCM/JIRA link daemon added a comment - 2018-01-10 09:12

SCM/JIRA link daemon added a comment - 2018-01-10 09:12 Code changed in jenkins User: Benjamin BONNET Path: src/main/lombok/eu/markov/jenkins/plugin/mvnmeta/MavenMetadataParameterValue.java http://jenkins-ci.org/commit/maven-metadata-plugin/ac3b6f65c4ff7d9a5d5acf054fa1e84ddf3487bd Log: Return param value to pipeline see https://issues.jenkins-ci.org/browse/JENKINS-38619

Collapse comment: SCM/JIRA link daemon added a comment - 2018-01-10 09:12

SCM/JIRA link daemon added a comment - 2018-01-10 09:12

Code changed in jenkins
User: Marc Rohlfs
Path:
src/main/lombok/eu/markov/jenkins/plugin/mvnmeta/MavenMetadataParameterValue.java
src/test/java/eu/markov/jenkins/plugin/mvnmeta/MavenMetadataParameterDefinitionTest.java
http://jenkins-ci.org/commit/maven-metadata-plugin/b6febe082a523f8ef217aa1693b1540d6b6c1822
Log:
Merge pull request #13 from bonnetb/patch-1

JENKINS-38619(https://issues.jenkins-ci.org/browse/JENKINS-38619)

Compare: https://github.com/jenkinsci/maven-metadata-plugin/compare/04f8423d627f...b6febe082a52

Expand comment: SCM/JIRA link daemon added a comment - 2018-01-10 09:12

SCM/JIRA link daemon added a comment - 2018-01-10 09:12 Code changed in jenkins User: Marc Rohlfs Path: src/main/lombok/eu/markov/jenkins/plugin/mvnmeta/MavenMetadataParameterValue.java src/test/java/eu/markov/jenkins/plugin/mvnmeta/MavenMetadataParameterDefinitionTest.java http://jenkins-ci.org/commit/maven-metadata-plugin/b6febe082a523f8ef217aa1693b1540d6b6c1822 Log: Merge pull request #13 from bonnetb/patch-1 JENKINS-38619 ( https://issues.jenkins-ci.org/browse/JENKINS-38619 ) Compare: https://github.com/jenkinsci/maven-metadata-plugin/compare/04f8423d627f...b6febe082a52

Collapse comment: Marc Rohlfs added a comment - 2018-01-10 09:45

Marc Rohlfs added a comment - 2018-01-10 09:45

Released with version 2.0.0

Expand comment: Marc Rohlfs added a comment - 2018-01-10 09:45

Marc Rohlfs added a comment - 2018-01-10 09:45 Released with version 2.0.0