Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38670

ability to enter build notes/parameters for a Manual step in the pipeline

    • Icon: New Feature New Feature
    • Resolution: Unresolved
    • Icon: Major Major
    • build-pipeline-plugin
    • None

      Wish the following new feature can be added to the Build Pipeline Plugin:
      Add an option to show Build Note for Manual Build in the configuration. If the option is checked, a build note link will be displayed besides the trigger button, which can pop up a buildPipeline.fillDialog window for the user to enter values for parameters.
      I added this ability in my local with using another job (configured as a parameter) for entering build note . Please see the attached screenshots. It would be nice if the note can be entered to build job directly. It would be helpful if such an ability can be provided in a formal release.

      Thanks.
      Derek

          [JENKINS-38670] ability to enter build notes/parameters for a Manual step in the pipeline

          DEREK LU added a comment -

          Dan,
          Thanks for looking into this. As long as the notes can be accessed in the job at run/build time, it should be good enough, as we can add steps in the job to store the notes.
          In my workaround (with a separated job), I wrote scripts to save the notes/comments into files then compose them into an HTML file, then move the html file under user Content for viewing.
          I downloaded https://github.com/jenkinsci/build-pipeline-plugin/tree/JENKINS-38670. after buit and installed, I didn't see note entering ability in the build pipeline, so I guess the change for the feature is not in yet.
          Thanks.
          Derek

          DEREK LU added a comment - Dan, Thanks for looking into this. As long as the notes can be accessed in the job at run/build time, it should be good enough, as we can add steps in the job to store the notes. In my workaround (with a separated job), I wrote scripts to save the notes/comments into files then compose them into an HTML file, then move the html file under user Content for viewing. I downloaded https://github.com/jenkinsci/build-pipeline-plugin/tree/JENKINS-38670 . after buit and installed, I didn't see note entering ability in the build pipeline, so I guess the change for the feature is not in yet. Thanks. Derek

          Dan Alvizu added a comment -

          I'm not sure I follow specifically where. Can you include a screenshot with a red X or whatever of what screen / UI you'd like to see them under

          Dan Alvizu added a comment - I'm not sure I follow specifically where. Can you include a screenshot with a red X or whatever of what screen / UI you'd like to see them under

          DEREK LU added a comment -

          I did uploaded three screenshots from my workaround when I open this request.
          Please see the attachment of the
          One is to configure the ability;
          Another one is a button/link in the pipeline job to popup a window (job as work around) to enter a note
          The third one is the job to create the note.
          I put the links of the screenshots here:
          https://issues.jenkins-ci.org/secure/attachment/34222/Build_note_config_option.jpg
          https://issues.jenkins-ci.org/secure/attachment/34218/Build_note_for_manual_build.jpg
          https://issues.jenkins-ci.org/secure/attachment/34221/popup_from_build_note_link.jpg
          It would be nice if the entering note feature is part of the job itself rather than a separated job like I did in the workaround.
          Thanks

          DEREK LU added a comment - I did uploaded three screenshots from my workaround when I open this request. Please see the attachment of the One is to configure the ability; Another one is a button/link in the pipeline job to popup a window (job as work around) to enter a note The third one is the job to create the note. I put the links of the screenshots here: https://issues.jenkins-ci.org/secure/attachment/34222/Build_note_config_option.jpg https://issues.jenkins-ci.org/secure/attachment/34218/Build_note_for_manual_build.jpg https://issues.jenkins-ci.org/secure/attachment/34221/popup_from_build_note_link.jpg It would be nice if the entering note feature is part of the job itself rather than a separated job like I did in the workaround. Thanks

          Code changed in jenkins
          User: Dan Alvizu
          Path:
          pom.xml
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/DownstreamProjectGridBuilder.java
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildVariablesHeader.java
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/FilteredVariablesHeader.java
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/NullColumnHeader.java
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/ParametersActionHeader.java
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension.java
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtensionDescriptor.java
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/SimpleColumnHeader.java
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/SimpleRowHeader.java
          src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/projectCardTemplate.jelly
          src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildVariablesHeader/config.jelly
          src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/FilteredVariablesHeader/config.jelly
          src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewTest.java
          src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectFormTest.java
          src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/FilteredVariablesHeaderTest.java
          http://jenkins-ci.org/commit/build-pipeline-plugin/c12811d41bec5ab3e213158af9ccf002bce87c91
          Log:
          Merge remote-tracking branch 'origin/master' into JENKINS-38670

          Conflicts:
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension.java
          src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewTest.java

          Compare: https://github.com/jenkinsci/build-pipeline-plugin/compare/d0d2352d9a71...c12811d41bec

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dan Alvizu Path: pom.xml src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/DownstreamProjectGridBuilder.java src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildVariablesHeader.java src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/FilteredVariablesHeader.java src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/NullColumnHeader.java src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/ParametersActionHeader.java src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension.java src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtensionDescriptor.java src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/SimpleColumnHeader.java src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/SimpleRowHeader.java src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/projectCardTemplate.jelly src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildVariablesHeader/config.jelly src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/FilteredVariablesHeader/config.jelly src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewTest.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectFormTest.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/FilteredVariablesHeaderTest.java http://jenkins-ci.org/commit/build-pipeline-plugin/c12811d41bec5ab3e213158af9ccf002bce87c91 Log: Merge remote-tracking branch 'origin/master' into JENKINS-38670 Conflicts: src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewTest.java Compare: https://github.com/jenkinsci/build-pipeline-plugin/compare/d0d2352d9a71...c12811d41bec

          Code changed in jenkins
          User: Dan Alvizu
          Path:
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension.java
          src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
          src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly
          src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
          src/main/webapp/js/build-pipeline.js
          http://jenkins-ci.org/commit/build-pipeline-plugin/48410da7763105ea9fa359666c83d90619196d6f
          Log:
          JENKINS-38670 update docs, add support for JS in handlebars templates

          This is a bit anathema to using handlebars but we're more or less stuck
          with it: provide a way for a BuildCardExtention to contribute JS to the
          build card, allowing for richer build cards.

          Also switched an appendTo() to an append() which during testing did
          an evaluation of the JS but only when it was in progress - this
          would result in build cards being hidden if the build is in progress.

          jQuery docs say these are equivalent, but they are liars.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dan Alvizu Path: src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension.java src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly src/main/webapp/js/build-pipeline.js http://jenkins-ci.org/commit/build-pipeline-plugin/48410da7763105ea9fa359666c83d90619196d6f Log: JENKINS-38670 update docs, add support for JS in handlebars templates This is a bit anathema to using handlebars but we're more or less stuck with it: provide a way for a BuildCardExtention to contribute JS to the build card, allowing for richer build cards. Also switched an appendTo() to an append() which during testing did an evaluation of the JS but only when it was in progress - this would result in build cards being hidden if the build is in progress. jQuery docs say these are equivalent, but they are liars.

          Code changed in jenkins
          User: Dan Alvizu
          Path:
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java
          http://jenkins-ci.org/commit/build-pipeline-plugin/12e776638739c7a4d93427297c0116ede5ded876
          Log:
          Merge branch 'master' into JENKINS-38670

          Compare: https://github.com/jenkinsci/build-pipeline-plugin/compare/48410da77631...12e776638739

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dan Alvizu Path: src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java http://jenkins-ci.org/commit/build-pipeline-plugin/12e776638739c7a4d93427297c0116ede5ded876 Log: Merge branch 'master' into JENKINS-38670 Compare: https://github.com/jenkinsci/build-pipeline-plugin/compare/48410da77631...12e776638739

          Code changed in jenkins
          User: James Forsee
          Path:
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension.java
          src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTriggerTest.java
          http://jenkins-ci.org/commit/build-pipeline-plugin/7eab095f175e7374dc71434d860b260e70071d38
          Log:
          Merge branch 'JENKINS-38670' of https://github.com/JamesForsee/build-pipeline-plugin into JENKINS-38670

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: James Forsee Path: src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTriggerTest.java http://jenkins-ci.org/commit/build-pipeline-plugin/7eab095f175e7374dc71434d860b260e70071d38 Log: Merge branch ' JENKINS-38670 ' of https://github.com/JamesForsee/build-pipeline-plugin into JENKINS-38670

          Code changed in jenkins
          User: Dan Alvizu
          Path:
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension.java
          src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTriggerTest.java
          http://jenkins-ci.org/commit/build-pipeline-plugin/6300e17fca0073c71f369a71bb7370b275e6f8dd
          Log:
          Merge pull request #108 from JamesForsee/JENKINS-38670

          [Fixed JENKINS-23532] Search Folders when trying to find upstream project

          Compare: https://github.com/jenkinsci/build-pipeline-plugin/compare/12e776638739...6300e17fca00

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dan Alvizu Path: src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTriggerTest.java http://jenkins-ci.org/commit/build-pipeline-plugin/6300e17fca0073c71f369a71bb7370b275e6f8dd Log: Merge pull request #108 from JamesForsee/ JENKINS-38670 [Fixed JENKINS-23532] Search Folders when trying to find upstream project Compare: https://github.com/jenkinsci/build-pipeline-plugin/compare/12e776638739...6300e17fca00

          Code changed in jenkins
          User: Dan Alvizu
          Path:
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension.java
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/StandardBuildCard.java
          src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
          src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/configure-entries.jelly
          src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly
          src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
          src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/StandardBuildCard/config.jelly
          src/main/webapp/js/build-pipeline.js
          src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewConstructorTest.java
          src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewDisplayNameTest.java
          src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewTest.java
          src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtensionTest.java
          src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/functionaltest/BuildPipelineViewTest.java
          src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/testsupport/PipelineWebDriverTestBase.java
          src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTriggerTest.java
          http://jenkins-ci.org/commit/build-pipeline-plugin/15b7b6a4ad16051d0692df379408f259637784a5
          Log:
          Merge pull request #111 from jenkinsci/JENKINS-38670

          Refactor build card into extensible class

          Compare: https://github.com/jenkinsci/build-pipeline-plugin/compare/6fab1fdbd64b...15b7b6a4ad16

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dan Alvizu Path: src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension.java src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/StandardBuildCard.java src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/configure-entries.jelly src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/StandardBuildCard/config.jelly src/main/webapp/js/build-pipeline.js src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewConstructorTest.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewDisplayNameTest.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewTest.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtensionTest.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/functionaltest/BuildPipelineViewTest.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/testsupport/PipelineWebDriverTestBase.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTriggerTest.java http://jenkins-ci.org/commit/build-pipeline-plugin/15b7b6a4ad16051d0692df379408f259637784a5 Log: Merge pull request #111 from jenkinsci/ JENKINS-38670 Refactor build card into extensible class Compare: https://github.com/jenkinsci/build-pipeline-plugin/compare/6fab1fdbd64b...15b7b6a4ad16

          Code changed in jenkins
          User: Dan Alvizu
          Path:
          src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTriggerTest.java
          http://jenkins-ci.org/commit/build-pipeline-plugin/e76da1ab0198d826a229b309e58c8ede9d3b1994
          Log:
          Merge pull request #112 from JamesForsee/JENKINS-38670

          Strengthen tests on the BuildCard's manual trigger

          Compare: https://github.com/jenkinsci/build-pipeline-plugin/compare/15b7b6a4ad16...e76da1ab0198

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dan Alvizu Path: src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTriggerTest.java http://jenkins-ci.org/commit/build-pipeline-plugin/e76da1ab0198d826a229b309e58c8ede9d3b1994 Log: Merge pull request #112 from JamesForsee/ JENKINS-38670 Strengthen tests on the BuildCard's manual trigger Compare: https://github.com/jenkinsci/build-pipeline-plugin/compare/15b7b6a4ad16...e76da1ab0198

            Unassigned Unassigned
            derekxlu DEREK LU
            Votes:
            4 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated: