Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38711

slave.jar should install UncaughtExceptionHandler

      The slave.jar should setup an UncaughtExceptionHandler to make it easier to diagnose things like NoClassDefFoundErrors which are impossible to debug once the original stack trace is lost.

       

      Plan of action:

      Remoting

      Threads  Expected Behavior
      SynchronousCommandTransport.ReaderThread  Log, terminate channel (see current generic error handling here
      PortForwarder  Log, call close()
      CopyThread  Log
      Engine  Log, kill remoting
      PingThread  Log, call onDead(Throwable)

       

      Core

      Threads  Expected Behavior
      PlainCLIProtocol.EitherSide.Reader  
      TaskThread  
      ViewJob.ReloadThread  
      Executor  
      Proc.LocalProc.StdinCopyThread  
      AbstractNodeMonitorDescriptor.Record  
      TcpSlaveAgentListener  Log, call shutdown()
      TcpSlaveAgentListener.ConnectionHandler  Log, close socket
      UDPBroadcastThread  
      StreamCopyThread  
      AsynchronousAdministrativeMonitor.FixThread  

          [JENKINS-38711] slave.jar should install UncaughtExceptionHandler

          Code changed in jenkins
          User: Rebecca Ysteboe
          Path:
          core/src/main/java/hudson/TcpSlaveAgentListener.java
          http://jenkins-ci.org/commit/jenkins/50bec3f68426b97344e1b87e4ef9a930f29ec778
          Log:
          JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads (#2986)

          • JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rebecca Ysteboe Path: core/src/main/java/hudson/TcpSlaveAgentListener.java http://jenkins-ci.org/commit/jenkins/50bec3f68426b97344e1b87e4ef9a930f29ec778 Log: JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads (#2986) JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads JENKINS-38711 Restart listener thread if it fails JENKINS-38711 Reschedule the thread on a delay JENKINS-38711 Allow the listener to actually be restarted JENKINS-38711 Minor updates based on feedback

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/TcpSlaveAgentListener.java
          http://jenkins-ci.org/commit/jenkins/885edb7c3841828906b57b1de2bf4d65d03527b4
          Log:
          Revert "JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads (#2986)"

          This reverts commit 50bec3f68426b97344e1b87e4ef9a930f29ec778.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/TcpSlaveAgentListener.java http://jenkins-ci.org/commit/jenkins/885edb7c3841828906b57b1de2bf4d65d03527b4 Log: Revert " JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads (#2986)" This reverts commit 50bec3f68426b97344e1b87e4ef9a930f29ec778.

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/TcpSlaveAgentListener.java
          http://jenkins-ci.org/commit/jenkins/a13a9dda2d7c517f012c103b8548ac7c3fc2ce9b
          Log:
          Merge pull request #3013 from jenkinsci/revert-2986-JENKINS-38711

          Revert "JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads"

          Compare: https://github.com/jenkinsci/jenkins/compare/50bec3f68426...a13a9dda2d7c

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/TcpSlaveAgentListener.java http://jenkins-ci.org/commit/jenkins/a13a9dda2d7c517f012c103b8548ac7c3fc2ce9b Log: Merge pull request #3013 from jenkinsci/revert-2986- JENKINS-38711 Revert " JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads" Compare: https://github.com/jenkinsci/jenkins/compare/50bec3f68426...a13a9dda2d7c

          Code changed in jenkins
          User: Rebecca Ysteboe
          Path:
          src/main/java/hudson/remoting/DaemonThreadFactory.java
          src/main/java/hudson/remoting/Engine.java
          src/main/java/hudson/remoting/FlightRecorderInputStream.java
          src/main/java/hudson/remoting/PingThread.java
          src/main/java/hudson/remoting/RemoteInputStream.java
          src/main/java/hudson/remoting/SynchronousCommandTransport.java
          src/main/java/hudson/remoting/forward/CopyThread.java
          src/main/java/hudson/remoting/forward/ForwarderFactory.java
          src/main/java/hudson/remoting/forward/PortForwarder.java
          http://jenkins-ci.org/commit/remoting/f999f5567e696b19db4b4b66cc71d4004344393b
          Log:
          JENKINS-38711 Add UncaughtExceptionHandlers to the various remoting threads (#187)

          • JENKINS-38711 Add UncaughtExceptionHandlers to the various remoting threads
          • JENKINS-38711 Don't close provided OutputStream in ForwarderFactory

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rebecca Ysteboe Path: src/main/java/hudson/remoting/DaemonThreadFactory.java src/main/java/hudson/remoting/Engine.java src/main/java/hudson/remoting/FlightRecorderInputStream.java src/main/java/hudson/remoting/PingThread.java src/main/java/hudson/remoting/RemoteInputStream.java src/main/java/hudson/remoting/SynchronousCommandTransport.java src/main/java/hudson/remoting/forward/CopyThread.java src/main/java/hudson/remoting/forward/ForwarderFactory.java src/main/java/hudson/remoting/forward/PortForwarder.java http://jenkins-ci.org/commit/remoting/f999f5567e696b19db4b4b66cc71d4004344393b Log: JENKINS-38711 Add UncaughtExceptionHandlers to the various remoting threads (#187) JENKINS-38711 Add UncaughtExceptionHandlers to the various remoting threads JENKINS-38711 Add handling to missed threads JENKINS-38711 Fix thread restart bug JENKINS-38711 Remove test exception JENKINS-38711 Move stream closures outside of CopyThread JENKINS-38711 Fix log levels JENKINS-38711 Fix CopyThread input bug JENKINS-38711 Don't close provided OutputStream in ForwarderFactory

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/jenkins/85319d0a579af8965854877f9e0f025c04af6db4
          Log:
          [JENKINS-38711, JENKINS-47132] - Update Remoting to 3.13

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/85319d0a579af8965854877f9e0f025c04af6db4 Log: [JENKINS-38711, JENKINS-47132] - Update Remoting to 3.13

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/jenkins/013a64879601fe5c4e98552c28abfcff260f2202
          Log:
          Merge pull request #3061 from oleg-nenashev/remoting/3.13

          [JENKINS-38711, JENKINS-47132] - Update Remoting to 3.13

          Compare: https://github.com/jenkinsci/jenkins/compare/7a0d73e9ceb1...013a64879601

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/013a64879601fe5c4e98552c28abfcff260f2202 Log: Merge pull request #3061 from oleg-nenashev/remoting/3.13 [JENKINS-38711, JENKINS-47132] - Update Remoting to 3.13 Compare: https://github.com/jenkinsci/jenkins/compare/7a0d73e9ceb1...013a64879601

          Code changed in jenkins
          User: Rebecca Ysteboe
          Path:
          core/src/main/java/hudson/TcpSlaveAgentListener.java
          http://jenkins-ci.org/commit/jenkins/62c4408c91b37767d700e84b87fed720426349ad
          Log:
          JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads (#3017)

          • JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rebecca Ysteboe Path: core/src/main/java/hudson/TcpSlaveAgentListener.java http://jenkins-ci.org/commit/jenkins/62c4408c91b37767d700e84b87fed720426349ad Log: JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads (#3017) JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads JENKINS-38711 Restart listener thread if it fails JENKINS-38711 Reschedule the thread on a delay JENKINS-38711 Allow the listener to actually be restarted JENKINS-38711 Minor updates based on feedback JENKINS-38711 Check to see if port has changed JENKINS-38711 Check for updates inside of rescheduler too JENKINS-38711 Remove port checks outside of the rescheduler JENKINS-38711 Add empty constructor to fix CI build JENKINS-38711 Remove unused port variable

          Daniel Beck added a comment -

          oleg_nenashev rysteboe Can we resolve this?

          Daniel Beck added a comment - oleg_nenashev rysteboe Can we resolve this?

          danielbeck yes, done

          Rebecca Ysteboe added a comment - danielbeck yes, done

          danielbeck oleg_nenashev actually I'm not sure what the status should be since the change is merged in but a release has not be created.  Please adjust the status as appropriate.

          Rebecca Ysteboe added a comment - danielbeck oleg_nenashev actually I'm not sure what the status should be since the change is merged in but a release has not be created.  Please adjust the status as appropriate.

            rysteboe Rebecca Ysteboe
            recampbell Ryan Campbell
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: