Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38711

slave.jar should install UncaughtExceptionHandler

    XMLWordPrintable

Details

    Description

      The slave.jar should setup an UncaughtExceptionHandler to make it easier to diagnose things like NoClassDefFoundErrors which are impossible to debug once the original stack trace is lost.

       

      Plan of action:

      Remoting

      Threads  Expected Behavior
      SynchronousCommandTransport.ReaderThread  Log, terminate channel (see current generic error handling here) 
      PortForwarder  Log, call close()
      CopyThread  Log
      Engine  Log, kill remoting
      PingThread  Log, call onDead(Throwable)

       

      Core

      Threads  Expected Behavior
      PlainCLIProtocol.EitherSide.Reader  
      TaskThread  
      ViewJob.ReloadThread  
      Executor  
      Proc.LocalProc.StdinCopyThread  
      AbstractNodeMonitorDescriptor.Record  
      TcpSlaveAgentListener  Log, call shutdown()
      TcpSlaveAgentListener.ConnectionHandler  Log, close socket
      UDPBroadcastThread  
      StreamCopyThread  
      AsynchronousAdministrativeMonitor.FixThread  

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-33395 Jenkins should install a default UncaughtExceptionHander

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-28499 tcpSlaveAgentListener not found

          • Blocker - Blocks development and/or testing work, production could not run.
          • Reopened

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-49415 Install additional UncaughtExceptionHandler in Engine

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link CloudBees Internal OSS-1493

          Web Link Jenkins Core ' PR 2986

          Web Link Remoting - PR 187

          Activity

            Ascending order - Click to sort in descending order
            View 10 older comments
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            pom.xml
            http://jenkins-ci.org/commit/jenkins/013a64879601fe5c4e98552c28abfcff260f2202
            Log:
            Merge pull request #3061 from oleg-nenashev/remoting/3.13

            [JENKINS-38711, JENKINS-47132] - Update Remoting to 3.13

            Compare: https://github.com/jenkinsci/jenkins/compare/7a0d73e9ceb1...013a64879601

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/013a64879601fe5c4e98552c28abfcff260f2202 Log: Merge pull request #3061 from oleg-nenashev/remoting/3.13 [JENKINS-38711, JENKINS-47132] - Update Remoting to 3.13 Compare: https://github.com/jenkinsci/jenkins/compare/7a0d73e9ceb1...013a64879601
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Rebecca Ysteboe
            Path:
            core/src/main/java/hudson/TcpSlaveAgentListener.java
            http://jenkins-ci.org/commit/jenkins/62c4408c91b37767d700e84b87fed720426349ad
            Log:
            JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads (#3017)

            • JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rebecca Ysteboe Path: core/src/main/java/hudson/TcpSlaveAgentListener.java http://jenkins-ci.org/commit/jenkins/62c4408c91b37767d700e84b87fed720426349ad Log: JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads (#3017) JENKINS-38711 Add UncaughtExceptionHandler to remoting related threads JENKINS-38711 Restart listener thread if it fails JENKINS-38711 Reschedule the thread on a delay JENKINS-38711 Allow the listener to actually be restarted JENKINS-38711 Minor updates based on feedback JENKINS-38711 Check to see if port has changed JENKINS-38711 Check for updates inside of rescheduler too JENKINS-38711 Remove port checks outside of the rescheduler JENKINS-38711 Add empty constructor to fix CI build JENKINS-38711 Remove unused port variable
            danielbeck Daniel Beck added a comment -

            oleg_nenashev rysteboe Can we resolve this?

            danielbeck Daniel Beck added a comment - oleg_nenashev rysteboe Can we resolve this?
            rysteboe Rebecca Ysteboe added a comment -

            danielbeck yes, done

            rysteboe Rebecca Ysteboe added a comment - danielbeck yes, done
            rysteboe Rebecca Ysteboe added a comment -

            danielbeck oleg_nenashev actually I'm not sure what the status should be since the change is merged in but a release has not be created.  Please adjust the status as appropriate.

            rysteboe Rebecca Ysteboe added a comment - danielbeck oleg_nenashev actually I'm not sure what the status should be since the change is merged in but a release has not be created.  Please adjust the status as appropriate.

            People

              rysteboe Rebecca Ysteboe
              recampbell Ryan Campbell
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: