[JENKINS-39153] GString not supported by automatically generated DSL

Type: Bug
Resolution: Fixed
Priority: Minor
Component/s: job-dsl-plugin
Labels:
None

Similar Issues:
Powered by SuggestiMate

Show

The following script will cause an error because of the GString argument to room

def SLACK_CHANNEL = 'bar'

job('example') {
  publishers {
    slackNotifier {
      room("foo-${SLACK_CHANNEL}")
      notifyAborted(true)
      notifyFailure(true)
      notifyNotBuilt(false)
      notifyUnstable(true)
      notifyBackToNormal(true)
      notifySuccess(false)
      notifyRepeatedFailure(false)
      startNotification(false)
      includeTestSummary(false)
      includeCustomMessage(false)
      customMessage(null)
      buildServerUrl(null)
      sendAs(null)
      commitInfoChoice('NONE')
      teamDomain(null)
      authToken(null)
    }
  }
}

console log:

Processing provided DSL script
ERROR: (script, line 6) No signature of method: javaposse.jobdsl.plugin.structs.DescribableContext.room() is applicable for argument types: (org.codehaus.groovy.runtime.GStringImpl) values: [foo-bar]
Possible solutions: wait(), dump(), any(), find(), grep(), wait(long)
Finished: FAILURE

is duplicated by

JENKINS-39502 ghprb couldn't pass the variable for triggerPhrase

Closed

links to

Groovy script fails to call Slack notification parameter from Jenkins DSL job

Rachel M. added a comment - 2016-10-20 23:25

It works in this way:

def SLACK_CHANNEL = 'bar'

job('example') {
  publishers {
    slackNotifier {
      room('foo-' + "${SLACK_CHANNEL}")
      notifyAborted(true)
      notifyFailure(true)
      notifyNotBuilt(false)
      notifyUnstable(true)
      notifyBackToNormal(true)
      notifySuccess(false)
      notifyRepeatedFailure(false)
      startNotification(false)
      includeTestSummary(false)
      includeCustomMessage(false)
      customMessage(null)
      buildServerUrl(null)
      sendAs(null)
      commitInfoChoice('NONE')
      teamDomain(null)
      authToken(null)
    }
  }
}

Rachel M. added a comment - 2016-10-20 23:25 It works in this way: def SLACK_CHANNEL = 'bar' job( 'example' ) { publishers { slackNotifier { room( 'foo-' + "${SLACK_CHANNEL}" ) notifyAborted( true ) notifyFailure( true ) notifyNotBuilt( false ) notifyUnstable( true ) notifyBackToNormal( true ) notifySuccess( false ) notifyRepeatedFailure( false ) startNotification( false ) includeTestSummary( false ) includeCustomMessage( false ) customMessage( null ) buildServerUrl( null ) sendAs( null ) commitInfoChoice( 'NONE' ) teamDomain( null ) authToken( null ) } } }

Daniel Spilker added a comment - 2016-10-21 07:05

This is still an issue, but a minor one since there is an easy workaround.

Daniel Spilker added a comment - 2016-10-21 07:05 This is still an issue, but a minor one since there is an easy workaround.

Rachel M. added a comment - 2016-10-21 11:50

Oh, sorry deeply daspilker, I've just seen you maintain the Job DSL Plugin and I thought it was a user's problem.

Rachel M. added a comment - 2016-10-21 11:50 Oh, sorry deeply daspilker , I've just seen you maintain the Job DSL Plugin and I thought it was a user's problem.

SCM/JIRA link daemon added a comment - 2016-10-30 19:53

Code changed in jenkins
User: Daniel Spilker
Path:
docs/Home.md
job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/structs/DescribableContext.groovy
job-dsl-plugin/src/test/groovy/javaposse/jobdsl/plugin/ExecuteDslScriptsSpec.groovy
job-dsl-plugin/src/test/groovy/javaposse/jobdsl/plugin/structs/DescribableContextSpec.groovy
job-dsl-plugin/src/test/resources/javaposse/jobdsl/plugin/gstring.groovy
http://jenkins-ci.org/commit/job-dsl-plugin/b1bcdc6790446e1a74c37d6d93740589119117a3
Log:
allow GString as argument type for auto-generated DSL

[FIXES JENKINS-39153]

SCM/JIRA link daemon added a comment - 2016-10-30 19:53 Code changed in jenkins User: Daniel Spilker Path: docs/Home.md job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/structs/DescribableContext.groovy job-dsl-plugin/src/test/groovy/javaposse/jobdsl/plugin/ExecuteDslScriptsSpec.groovy job-dsl-plugin/src/test/groovy/javaposse/jobdsl/plugin/structs/DescribableContextSpec.groovy job-dsl-plugin/src/test/resources/javaposse/jobdsl/plugin/gstring.groovy http://jenkins-ci.org/commit/job-dsl-plugin/b1bcdc6790446e1a74c37d6d93740589119117a3 Log: allow GString as argument type for auto-generated DSL [FIXES JENKINS-39153]

SCM/JIRA link daemon added a comment - 2016-10-30 19:53

Code changed in jenkins
User: Daniel Spilker
Path:
docs/Home.md
job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/structs/DescribableContext.groovy
job-dsl-plugin/src/test/groovy/javaposse/jobdsl/plugin/ExecuteDslScriptsSpec.groovy
job-dsl-plugin/src/test/groovy/javaposse/jobdsl/plugin/structs/DescribableContextSpec.groovy
job-dsl-plugin/src/test/resources/javaposse/jobdsl/plugin/gstring.groovy
http://jenkins-ci.org/commit/job-dsl-plugin/312a71e6ab0333c23f59e01992c82df882d32149
Log:
Merge pull request #942 from daspilker/~~JENKINS-39153~~

~~JENKINS-39153~~ allow GString as argument type for auto-generated DSL

Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/9a9e94c68d12...312a71e6ab03

SCM/JIRA link daemon added a comment - 2016-10-30 19:53 Code changed in jenkins User: Daniel Spilker Path: docs/Home.md job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/structs/DescribableContext.groovy job-dsl-plugin/src/test/groovy/javaposse/jobdsl/plugin/ExecuteDslScriptsSpec.groovy job-dsl-plugin/src/test/groovy/javaposse/jobdsl/plugin/structs/DescribableContextSpec.groovy job-dsl-plugin/src/test/resources/javaposse/jobdsl/plugin/gstring.groovy http://jenkins-ci.org/commit/job-dsl-plugin/312a71e6ab0333c23f59e01992c82df882d32149 Log: Merge pull request #942 from daspilker/ JENKINS-39153 JENKINS-39153 allow GString as argument type for auto-generated DSL Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/9a9e94c68d12...312a71e6ab03

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: Rachel M. added a comment - 2016-10-20 23:25

Expand comment: Rachel M. added a comment - 2016-10-20 23:25

Collapse comment: Daniel Spilker added a comment - 2016-10-21 07:05

Expand comment: Daniel Spilker added a comment - 2016-10-21 07:05

Collapse comment: Rachel M. added a comment - 2016-10-21 11:50

Expand comment: Rachel M. added a comment - 2016-10-21 11:50

Collapse comment: SCM/JIRA link daemon added a comment - 2016-10-30 19:53

Expand comment: SCM/JIRA link daemon added a comment - 2016-10-30 19:53

Collapse comment: SCM/JIRA link daemon added a comment - 2016-10-30 19:53

Expand comment: SCM/JIRA link daemon added a comment - 2016-10-30 19:53

People

Dates