Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39239

Mattermost Plugin 2.0+: No field 'showCommitList'

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Since version 2.0, the Mattermost Plugin no longer has a field showCommitList.
      This leads to Jenkins finding "unreadable data":

      MissingFieldException: No field 'showCommitList' found in class 'jenkins.plugins.mattermost.MattermostNotifier'
      

      Instead, there's now a field commitInfoChoice, which is an enum with (currently) three possible values NONE, AUTHORS, or AUTHORS_AND_TITLES.

      I've also looked at the new generic DSL version, but going from

      mattermost {
      	endpoint(MATTERMOST_HOOK_URL)
      	notifyFailure()
      }
      

      to

      mattermostNotifier {
      	endpoint(MATTERMOST_HOOK_URL)
      	room(null)
      	icon(null)
      	buildServerUrl(null)
      	sendAs(null)
      	startNotification(false)
      	notifyAborted(false)
      	notifyFailure(true)
      	notifyNotBuilt(false)
      	notifySuccess(false)
      	notifyUnstable(false)
      	notifyBackToNormal(false)
      	notifyRepeatedFailure(false)
      	includeTestSummary(false)
      	commitInfoChoice('NONE')
      	includeCustomMessage(false)
      	customMessage(null)
      }
      

      is not exactly an attractive proposition (undocumented, no IDE support, can't leave out default valued fields, very little advantage over a configure block).

        Attachments

          Activity

          Hide
          daspilker Daniel Spilker added a comment -

          Works as expected, nice!

          Show
          daspilker Daniel Spilker added a comment - Works as expected, nice!
          Hide
          jovandeginste Jo Vandeginste added a comment -

          Seriously? This easy...?

          Show
          jovandeginste Jo Vandeginste added a comment - Seriously? This easy...?
          Hide
          daspilker Daniel Spilker added a comment -

          Yup. Merge it, cut a release and done

          Show
          daspilker Daniel Spilker added a comment - Yup. Merge it, cut a release and done
          Hide
          jovandeginste Jo Vandeginste added a comment -

          New release published: 2.3.0 (I ran it in my own environment first to make sure nothing broke)

          Show
          jovandeginste Jo Vandeginste added a comment - New release published: 2.3.0 (I ran it in my own environment first to make sure nothing broke)
          Hide
          jovandeginste Jo Vandeginste added a comment -

          Marking as fixed; if the new version is still missing something, feel free to reopen!

          Show
          jovandeginste Jo Vandeginste added a comment - Marking as fixed; if the new version is still missing something, feel free to reopen!

            People

            Assignee:
            jovandeginste Jo Vandeginste
            Reporter:
            hoeferh Henning Hoefer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: