Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39443

Sanitise description string as it may contains troublesome chars

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Cannot Reproduce
    • Icon: Major Major
    • swarm-plugin
    • None

      jenkins swarm client can setup node description which is reported by Jenkins as unsafe.
      This is done with option -description <string> which passes this as node name seen in Jenkins node list.

      One example is jenkins-swarm.jar -description "swarm_ip:127.0.0.1" --the : colon char will cause Jenkins to rise error anytime when swarm node configuration is being saved (this leads to no save action). There may be other outcomes with non valid node descriptions.

          [JENKINS-39443] Sanitise description string as it may contains troublesome chars

          Paul Walter created issue -
          Mark Hudson made changes -
          Description Original: jenkins swarm client can setup node description which is reported by Jenkins as unsafe.
          This is done with option -description <string> which passes this as node name seen in Jenkins node list.

          One example is jenkins-swarm.jar -description "swarm_ip:127.0.0.1" , char : will cause Jenkins to rise error anytime when swarm node configuration is being saved (this leads to no save action). There may be other outcomes with non valid node descriptions.           		New: jenkins swarm client can setup node description which is reported by Jenkins as unsafe.
          This is done with option -description <string> which passes this as node name seen in Jenkins node list.

          One example is jenkins-swarm.jar -description "swarm_ip:127.0.0.1" --the {{:}} colon char will cause Jenkins to rise error anytime when swarm node configuration is being saved (this leads to no save action). There may be other outcomes with non valid node descriptions.
          Mark Hudson made changes -
          Link New: This issue relates to JENKINS-40663 [ JENKINS-40663 ]
          Mark Hudson made changes -
          Link New: This issue relates to JENKINS-28022 [ JENKINS-28022 ]

          Oleg Nenashev added a comment -

          KK does not maintain this plugin anymore. Moving to unassigned to set the expectation

          Oleg Nenashev added a comment - KK does not maintain this plugin anymore. Moving to unassigned to set the expectation
          Oleg Nenashev made changes -
          Assignee Original: Kohsuke Kawaguchi [ kohsuke ]
          Basil Crow made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]

          Basil Crow added a comment -

          This is no longer an issue in recent versions of Swarm client and Jenkins core. See the test added in #100.

          Basil Crow added a comment - This is no longer an issue in recent versions of Swarm client and Jenkins core. See the test added in #100 .
          Basil Crow made changes -
          Resolution New: Cannot Reproduce [ 5 ]
          Status Original: Open [ 1 ] New: Closed [ 6 ]

            Unassigned Unassigned
            omka Paul Walter
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: