Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39620

Saving a job with Active Choice 1.4 parameters after upgrade to v1.5 resets scriptlet parameters

XMLWordPrintable

      After upgrading to the Active Choices v1.5 jobs originally containing Active Choices v1.4 definitions load and work fine. However, if the configuration of one of these jobs now gets saved (you don't even need to modify it) all parameters to scriptlets used in Active Choices are dropped and the form UI does not render.

      See attached screenshot on the parameter definition changes before and after the configuration is changed.

        1. image-2016-11-09-10-45-19-649.png
          image-2016-11-09-10-45-19-649.png
          70 kB
        2. uno-choice.hpi
          995 kB
        3. uno-choice-1.5.2-SNAPSHOT-20161115122800.hpi
          995 kB
        4. uno-choice-1.5.2-SNAPSHOT-20161116130500.hpi
          996 kB

          [JENKINS-39620] Saving a job with Active Choice 1.4 parameters after upgrade to v1.5 resets scriptlet parameters

          Ioannis Moutsatsos created issue -

          Bruno P. Kinoshita added a comment -

          At least related, if not duplicated.

          Bruno P. Kinoshita added a comment - At least related, if not duplicated.
          Bruno P. Kinoshita made changes -
          Link New: This issue is related to JENKINS-39534 [ JENKINS-39534 ]

          Bruno P. Kinoshita added a comment -

          Oh! Fixing a FindBugs warning that was preventing the last release, I marked the secureScript and fallbackSecureScript, both as "transient".

          So these fields were not being persisted after you restarted Jenkins.

          I believe I know how to fix it, and once I've tested it, will cut a new release.

          Sorry for the trouble.

          Bruno P. Kinoshita added a comment - Oh! Fixing a FindBugs warning that was preventing the last release, I marked the secureScript and fallbackSecureScript, both as "transient". So these fields were not being persisted after you restarted Jenkins. I believe I know how to fix it, and once I've tested it, will cut a new release. Sorry for the trouble.
          Bruno P. Kinoshita made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Bruno P. Kinoshita
          Path:
          src/findbugs/excludesFilter.xml
          src/main/java/org/biouno/unochoice/model/GroovyScript.java
          http://jenkins-ci.org/commit/active-choices-plugin/cac73ce953ce6419e14ad2ad7a12b0982fb8652b
          Log:
          [FIXED JENKINS-39620] and JENKINS-39534 Revert change that marked fields as transient, and add FindBugs exclusion filters

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: src/findbugs/excludesFilter.xml src/main/java/org/biouno/unochoice/model/GroovyScript.java http://jenkins-ci.org/commit/active-choices-plugin/cac73ce953ce6419e14ad2ad7a12b0982fb8652b Log: [FIXED JENKINS-39620] and JENKINS-39534 Revert change that marked fields as transient, and add FindBugs exclusion filters

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Bruno P. Kinoshita
          Path:
          src/findbugs/excludesFilter.xml
          src/main/java/org/biouno/unochoice/model/GroovyScript.java
          http://jenkins-ci.org/commit/active-choices-plugin/44c21fc6bab67a538d785712d2a3aa302d20ea1a
          Log:
          [FIXED JENKINS-39620] and JENKINS-39534 Revert change that marked fields as transient, and add FindBugs exclusion filters

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: src/findbugs/excludesFilter.xml src/main/java/org/biouno/unochoice/model/GroovyScript.java http://jenkins-ci.org/commit/active-choices-plugin/44c21fc6bab67a538d785712d2a3aa302d20ea1a Log: [FIXED JENKINS-39620] and JENKINS-39534 Revert change that marked fields as transient, and add FindBugs exclusion filters
          Bruno P. Kinoshita made changes -
          Attachment New: uno-choice.hpi [ 34787 ]

          Ioannis Moutsatsos added a comment -

          Thanks Bruno! Good catch!
          I will give this hpi a try first thing this morning at work. In my case, the parameter persistence issue did not require a Jenkins restart to manifest. As soon as the configuration was 'applied' or 'saved' the parameters were lost.

          Ioannis Moutsatsos added a comment - Thanks Bruno! Good catch! I will give this hpi a try first thing this morning at work. In my case, the parameter persistence issue did not require a Jenkins restart to manifest. As soon as the configuration was 'applied' or 'saved' the parameters were lost.

          Wynand van Wyk added a comment -

          Holy crap, this bug just wiped all of our parameters for all our jobs on our jenkins instance using this plugin. I ran a planned "bulk update and save" of all our job configs and now everything is gone.

          The UI also displays the words "ParametersDescription" instead of "Parameters" like it did in 1.4.

          I'm at a loss for words. This will keep me up through the night! haha! 1.5 is not usable. It should be removed completely from the plugins download list.

          Thank you for the great plugin though! Aside from this disaster, it has helped us tremendously otherwise. Any idea how long the wait would be for 1.6 ? Or is rolling back to 1.4 my best bet?

          Wynand van Wyk added a comment - Holy crap, this bug just wiped all of our parameters for all our jobs on our jenkins instance using this plugin. I ran a planned "bulk update and save" of all our job configs and now everything is gone. The UI also displays the words "ParametersDescription" instead of "Parameters" like it did in 1.4. I'm at a loss for words. This will keep me up through the night! haha! 1.5 is not usable. It should be removed completely from the plugins download list. Thank you for the great plugin though! Aside from this disaster, it has helped us tremendously otherwise. Any idea how long the wait would be for 1.6 ? Or is rolling back to 1.4 my best bet?

            kinow Bruno P. Kinoshita
            ioannis Ioannis Moutsatsos
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: