Regression in user name handling: "Bob <bob@x.com>" -> "Bob _bob@x.com>"

This issue is archived. You can view it, but you can't modify it. Learn more

XMLWordPrintable

      Between 1.309 and 1.313, display of Mercurial users was broken. For example,

      http://hg.netbeans.org/core-main/rev/3c5fac30b9a4

      shows a user "Tomas Hurka <thurka@netbeans.org>" and changelog.xml contains this
      name as well. But

      http://deadlock.netbeans.org/hudson/job/NB-Core-Build/2834/changes

      shows "Tomas Hurka _thurka@netbeans.org>"

      as does

      http://deadlock.netbeans.org/hudson/job/NB-Core-Build/2834/api/xml

      so this broken name appears also in the NetBeans changelog view.

      The culprit seems to be 18760 in User.java:

      id = id.replace('
      ', '').replace('/', '').replace('<','_');

      I am guessing that the correct fix is for the User constructor to take both id
      and fullName params, with fullName being the unescaped original arg to User.get.

            Assignee:
            Unassigned
            Reporter:
            Jesse Glick
            Archiver:
            Jenkins Service Account

              Created:
              Updated:
              Resolved:
              Archived: