tscherler ahhhh I thought we had killed all of those problems

tscherler jamesdumay not sure how but that link was a bad paste in irc (something else escaped). Pull requests DO open even when in a folder with spaces in the name (I just tested it to confirm), so ignore that "bad url" problem. Ie they are fine - everything is fine. How are you? But they are escaped correctly.

The real problem you can see on PRs OR on branches. open a branch say like:

http://localhost:8080/jenkins/blue/organizations/jenkins/keith/detail/michaelneale/9/pipeline

to reproduce, pick any old multibranch project then change the ID to something non extistent, you can see it even in that case, nothign specific to PRs or URIs, just for non existing

http://localhost:8080/jenkins/blue/organizations/jenkins/keith/detail/michaelneale/fjldsfdsafdsafdsa/pipeline

You will see in console there is a 404 response (correct) but the GUI should show the awesome 404 page, not a blank screen.

blue ocean has a great 404, page. Just fantastic page. What that page can do is amazing:

michaelneale yeah you are right. I actually can add another inconsistency

http://localhost:8080/jenkins/blue/organizations/jenkins/longLog/activiy/

or http://localhost:8080/jenkins/blue/s/

...actually it is hard to bring up the shinny page, still looking for a url pattern

found it in details

I am trying to reproduce this on my local instance but yet without luck.

I created a freestyle project and did a build. Then went to detail view, then removed the project and reloaded. I get the 404.

Maybe it is related to the dogfood instance which do not contain a prefix.

The only mentioning of the shiny one is in the pipelinePage.

       if (pipeline && pipeline.$failed) {
            return <NotFound />;
        }

Meaning I need to refactor the whole concept of the 404 pages.

The PR https://github.com/jenkinsci/blueocean-plugin/pull/622 will cover all but some MOBX related 404, which will be picked up by imeredith in another ticket.

Can you make a follow on ticket? the case I saw that didn't work was pipeline results screen (is that what you mean?)

Exactly michaelneale the idea is that the mbox component will return always a valid object and not throw an exception when a 404 or 500 on the backend happens. This way each view can return the NotFound component they want, when they want.

JENKINS-40032 please review if I have covered all bases michaelneale