Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39809

404s pages are inconsistent - blank page, ugly 404 and flashy 404

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • blueocean-plugin
    • None
    • arctic, tasman

      In scope

      • If the run result is opened and no run or job exists it should go to the 404 page.

      Context
      https://ci.jenkins.io/blue/organizations/jenkins/Infra%2Fpatron/detail/PR-16/1/pipeline/

      [2016-11-17 04:48:18]  <@michaelneale>	@danielbeck: that pull request isn't in the UI any more
      [2016-11-17 04:48:40]  <@michaelneale>	@danielbeck: which may be why is blank (but should be 404)
      [2016-11-17 04:48:44]  <@danielbeck>	michaelneale merged?
      [2016-11-17 04:48:51]  <@danielbeck>	I merged it earlier
      [2016-11-17 04:48:56]  <@danielbeck>	but wtf this must be nicer
      [2016-11-17 04:49:05]  <@michaelneale>	Yes. Can you open ticket?
      [2016-11-17 04:49:07]  <@michaelneale>	That's bad.
      [2016-11-17 04:49:21]  <@i386>	so it looks like we are not handling 404s on that route anymore
      [2016-11-17 04:49:25]  <@i386>	so thats super broken
      [2016-11-17 04:51:44]  <@michaelneale>	Ok yes.
      [2016-11-17 04:52:04]  <@michaelneale>	Need to add acceptance test for that. I shall.

          [JENKINS-39809] 404s pages are inconsistent - blank page, ugly 404 and flashy 404

          Daniel Beck created issue -
          James Dumay made changes -
          Description Original: https://ci.jenkins.io/blue/organizations/jenkins/Infra%2Fpatron/detail/PR-16/1/pipeline/

          {noformat}[2016-11-17 04:48:18] <@michaelneale> @danielbeck: that pull request isn't in the UI any more
          [2016-11-17 04:48:40] <@michaelneale> @danielbeck: which may be why is blank (but should be 404)
          [2016-11-17 04:48:44] <@danielbeck> michaelneale merged?
          [2016-11-17 04:48:51] <@danielbeck> I merged it earlier
          [2016-11-17 04:48:56] <@danielbeck> but wtf this must be nicer
          [2016-11-17 04:49:05] <@michaelneale> Yes. Can you open ticket?
          [2016-11-17 04:49:07] <@michaelneale> That's bad.
          [2016-11-17 04:49:21] <@i386> so it looks like we are not handling 404s on that route anymore
          [2016-11-17 04:49:25] <@i386> so thats super broken
          [2016-11-17 04:51:44] <@michaelneale> Ok yes.
          [2016-11-17 04:52:04] <@michaelneale> Need to add acceptance test for that. I shall.{noformat}
          New: *In scope*
          * If the run result is opened and no run or job exists it should go to the 404 page.


          *Context*
          https://ci.jenkins.io/blue/organizations/jenkins/Infra%2Fpatron/detail/PR-16/1/pipeline/

          {noformat}[2016-11-17 04:48:18] <@michaelneale> @danielbeck: that pull request isn't in the UI any more
          [2016-11-17 04:48:40] <@michaelneale> @danielbeck: which may be why is blank (but should be 404)
          [2016-11-17 04:48:44] <@danielbeck> michaelneale merged?
          [2016-11-17 04:48:51] <@danielbeck> I merged it earlier
          [2016-11-17 04:48:56] <@danielbeck> but wtf this must be nicer
          [2016-11-17 04:49:05] <@michaelneale> Yes. Can you open ticket?
          [2016-11-17 04:49:07] <@michaelneale> That's bad.
          [2016-11-17 04:49:21] <@i386> so it looks like we are not handling 404s on that route anymore
          [2016-11-17 04:49:25] <@i386> so thats super broken
          [2016-11-17 04:51:44] <@michaelneale> Ok yes.
          [2016-11-17 04:52:04] <@michaelneale> Need to add acceptance test for that. I shall.{noformat}
          James Dumay made changes -
          Assignee Original: Michael Neale [ michaelneale ] New: Thorsten Scherler [ tscherler ]

          James Dumay added a comment -

          tscherler when you've moved on from i18n can you take a peek at this please?

          James Dumay added a comment - tscherler when you've moved on from i18n can you take a peek at this please?
          James Dumay made changes -
          Epic Link New: JENKINS-35750 [ 171713 ]
          James Dumay made changes -
          Sprint New: arctic [ 131 ]
          Thorsten Scherler made changes -
          Attachment New: Screenshot from 2016-11-17 12-18-59.png [ 34884 ]

          The path of the resources are wrong for the rest services it should not decode "Infra%2Fpatron" to "Infra/patron"

          Thorsten Scherler added a comment - The path of the resources are wrong for the rest services it should not decode "Infra%2Fpatron" to "Infra/patron"

          James Dumay added a comment -

          tscherler ahhhh I thought we had killed all of those problems

          James Dumay added a comment - tscherler ahhhh I thought we had killed all of those problems
          Michael Neale made changes -
          Attachment New: donald--Make-404-pages-great-again.png [ 34893 ]

            tscherler Thorsten Scherler
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: