Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40137

Open in blue ocean button does not work for runs when the branch name contains a /

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • blueocean-plugin
    • None
    • frank, christmas

      Summary: URL is double encoded in classic, but should not be when opening blue ocean.

      There is no ATH coverage for "open blue ocean" (should there be?)

      404 should be another ticket (likely already is one open).

      Steps to reproduce

      1. Go to https://ci.blueocean.io/job/blueocean/job/bug%252FJENKINS-39158/1/
      2. Click open in blue ocean
      3. No 404, the page is broken
      4. URL is https://ci.blueocean.io/blue/organizations/jenkins/blueocean/detail/bug%252FJENKINS-39158/1/

      What should happen
      The real URL to this run is https://ci.blueocean.io/blue/organizations/jenkins/blueocean/detail/bug%2FJENKINS-39158/1/pipeline

      Why is the 404 handling broken? (A: should be in another ticket, not related to this)
      Where is the ATH for this? (A: isn't a regression, no coverage for open button yet - but may as well should be)

          [JENKINS-40137] Open in blue ocean button does not work for runs when the branch name contains a /

          Michael Neale added a comment - - edited

          Michael Neale added a comment - - edited https://ci.blueocean.io/blue/organizations/jenkins/blueocean/detail/bug%252FJENKINS-39158/1/ Ah: https://ci.blueocean.io/blue/organizations/jenkins/blueocean/detail/bug%2FJENKINS-39158/1/pipeline should be the URL. Blue ocean does not double url encode, classic does. tfennelly this looks like a small ish thing.

          Tom FENNELLY added a comment -

          jamesdumay ...

          There is no ATH coverage for "open blue ocean" (should there be?)

          Is that a question or faulty conclusion?

          Tom FENNELLY added a comment - jamesdumay ... There is no ATH coverage for "open blue ocean" (should there be?) Is that a question or faulty conclusion ?

          Michael Neale added a comment -

          tfennelly right didn't see that. In that case, its just missing some extra cases.

          Michael Neale added a comment - tfennelly right didn't see that. In that case, its just missing some extra cases.

          Tom FENNELLY added a comment - PRs: https://github.com/jenkinsci/blueocean-plugin/pull/676 https://github.com/jenkinsci/blueocean-acceptance-test/pull/92

          Code changed in jenkins
          User: Tom Fennelly
          Path:
          run.sh
          src/test/java/utils/DevRunner.java
          src/test/js/edgeCases/folder.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/838879c4559ce3e83e264f63e83f8383c6fb2278
          Log:
          [FIX JENKINS-40137] Test for: Fix encoding of job name in "Open Blue Ocean" URLs (#92)

          • Add ability to connect debugger to Jenkins instance
          • Added a check on the run details page after navigating via "Open Blue Ocean" for MBP with a slash in the branch name

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Tom Fennelly Path: run.sh src/test/java/utils/DevRunner.java src/test/js/edgeCases/folder.js http://jenkins-ci.org/commit/blueocean-acceptance-test/838879c4559ce3e83e264f63e83f8383c6fb2278 Log: [FIX JENKINS-40137] Test for: Fix encoding of job name in "Open Blue Ocean" URLs (#92) Add ability to connect debugger to Jenkins instance Added a check on the run details page after navigating via "Open Blue Ocean" for MBP with a slash in the branch name

            tfennelly Tom FENNELLY
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: