Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40224

Mailer links of failed jobs are broken with BlueOcean plugin, not redirecting properly

    • tethys, pannonian

      After installing BlueOcean beta, all links in the emails were changed to use BlueOcean URLs (which I find inconvenient, this should not be automatic in my opinion and I have been able to find a config option for this − happy to open a separate bug for this).

      For the emails indicating a failure, the links are broken. Here are some examples:

      After uninstalling the BlueOcean plugins, the links are functional again:

          [JENKINS-40224] Mailer links of failed jobs are broken with BlueOcean plugin, not redirecting properly

          James Dumay added a comment - - edited

          jeanfred sorry you ran into a problem. What was broken about the links we generated? Did the page 404, etc?

          We do have a configurable option in development for switching your links between Blue Ocean and Classic Jenkins. You can watch it on JENKINS-39580.

          You mentioned that being switched to Blue Ocean is inconvenient. Is there something missing from Blue Ocean today that makes it hard for you to switch away from Classic?

          James Dumay added a comment - - edited jeanfred sorry you ran into a problem. What was broken about the links we generated? Did the page 404, etc? We do have a configurable option in development for switching your links between Blue Ocean and Classic Jenkins. You can watch it on JENKINS-39580 . You mentioned that being switched to Blue Ocean is inconvenient. Is there something missing from Blue Ocean today that makes it hard for you to switch away from Classic?

          Hi, thanks for answering to this issue !

          I got around to try this again today (after submitting this issue I uninstalled all BlueOcean − had to reinstall them). I reinstalled everything but specifically not BlueOcean Display URL plugin. The problem is still there.

          > What was broken about the links we generated? Did the page 404, etc?

          Yes, the page does go in 404, with « Jenkins could not find the page you were looking for. Check the URL for errors or press the back button. » and the nice wave background (this must have been updated − I seem to recall it was simpler last week.

          > We do have a configurable option in development for switching your links between Blue Ocean and Classic Jenkins. You can watch it on JENKINS-39580.

          Thanks. I do think this is a necessary feature !

          > You mentioned that being switched to Blue Ocean is inconvenient. Is there something missing from Blue Ocean today that makes it hard for you to switch away from Classic?

          Generally speaking, I installed BlueOcean to get my team a sneak peak at what might be coming, so that they can give feedback on whether it is something they would want (generally the initial response is positive for now), however it is disruptive to be switched away straight away.
          In particular, people have found finding jobs very frustrating. There is no search box as far as I can see, and the front page is quite useless since it is heavily paginated − we have more than 600 jobs, clicking « Read more » plenty of time does not work well. (We are not using Pipelines, and are not likely either to switch as we are very heavy users of Jenkins Job Builder).

          Hope that helps !

          Jean-Frédéric added a comment - Hi, thanks for answering to this issue ! I got around to try this again today (after submitting this issue I uninstalled all BlueOcean − had to reinstall them). I reinstalled everything but specifically not BlueOcean Display URL plugin. The problem is still there. > What was broken about the links we generated? Did the page 404, etc? Yes, the page does go in 404, with « Jenkins could not find the page you were looking for. Check the URL for errors or press the back button. » and the nice wave background (this must have been updated − I seem to recall it was simpler last week. > We do have a configurable option in development for switching your links between Blue Ocean and Classic Jenkins. You can watch it on JENKINS-39580 . Thanks. I do think this is a necessary feature ! > You mentioned that being switched to Blue Ocean is inconvenient. Is there something missing from Blue Ocean today that makes it hard for you to switch away from Classic? Generally speaking, I installed BlueOcean to get my team a sneak peak at what might be coming, so that they can give feedback on whether it is something they would want (generally the initial response is positive for now), however it is disruptive to be switched away straight away. In particular, people have found finding jobs very frustrating. There is no search box as far as I can see, and the front page is quite useless since it is heavily paginated − we have more than 600 jobs, clicking « Read more » plenty of time does not work well. (We are not using Pipelines, and are not likely either to switch as we are very heavy users of Jenkins Job Builder). Hope that helps !

          James Dumay added a comment - - edited

          jeanfred would the jobs you received 404 for happen to be Matrix projects or any other non-Pipeline or non-Freestyle job type? I suspect what you might be seeing is the problem described in JENKINS-40446 (which we have a fix for and is about to be released!)

          James Dumay added a comment - - edited jeanfred would the jobs you received 404 for happen to be Matrix projects or any other non-Pipeline or non-Freestyle job type? I suspect what you might be seeing is the problem described in JENKINS-40446 (which we have a fix for and is about to be released!)

          Jean-Frédéric added a comment - - edited

          > would the jobs you received 404 for happen to be Matrix projects or any other non-Pipeline or non-Freestyle job type?

          No, these are all Freestyle jobs.

          I think the root problem lies more with the Mailer plugin, which creates links like jenkins.acme.com/job/jobB/777/-------/. But these links are redirect properly with classic URLs, not with BlueOcean URLs.

          Jean-Frédéric added a comment - - edited > would the jobs you received 404 for happen to be Matrix projects or any other non-Pipeline or non-Freestyle job type? No, these are all Freestyle jobs. I think the root problem lies more with the Mailer plugin, which creates links like jenkins.acme.com/job/jobB/777/-------/ . But these links are redirect properly with classic URLs, not with BlueOcean URLs.

          James Dumay added a comment -

          jeanfred we would love your input on JENKINS-38982 which aims to reduce the pagination issue you described.

          James Dumay added a comment - jeanfred we would love your input on JENKINS-38982 which aims to reduce the pagination issue you described.

          James Dumay added a comment -

          Good news is that I tracked this down to a regression when we introduced the hook to allow Blue Ocean URLs to override the classic ones. It was a simple fix and it is currently in review. You will require an upgrade to the mailer plugin to receive this fix.

          James Dumay added a comment - Good news is that I tracked this down to a regression when we introduced the hook to allow Blue Ocean URLs to override the classic ones. It was a simple fix and it is currently in review . You will require an upgrade to the mailer plugin to receive this fix.

          James Dumay added a comment -

          jeanfred you should be able to set a preference in your user profile so that you receive classic Jenkins links instead of Blue Ocean and there is a fix for Matrix projects in beta 21 this week.

          James Dumay added a comment - jeanfred you should be able to set a preference in your user profile so that you receive classic Jenkins links instead of Blue Ocean and there is a fix for Matrix projects in beta 21 this week.

          James Dumay added a comment -

          This fix should appear in mailer 1.19 shortly.

          Thanks jglick for merging and releasing this one.

          James Dumay added a comment - This fix should appear in mailer 1.19 shortly. Thanks jglick for merging and releasing this one.

          Code changed in jenkins
          User: Evaristo Gutiérrez
          Path:
          src/main/java/hudson/tasks/MailSender.java
          src/test/java/hudson/tasks/MailerTest.java
          http://jenkins-ci.org/commit/mailer-plugin/11b6c3a5119d29e27b8dfd1b5a0080b5b9497da7
          Log:
          JENKINS-41881 Include automated test to cover fix for JENKINS-40224

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Evaristo Gutiérrez Path: src/main/java/hudson/tasks/MailSender.java src/test/java/hudson/tasks/MailerTest.java http://jenkins-ci.org/commit/mailer-plugin/11b6c3a5119d29e27b8dfd1b5a0080b5b9497da7 Log: JENKINS-41881 Include automated test to cover fix for JENKINS-40224

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/hudson/tasks/MailSender.java
          src/test/java/hudson/tasks/MailerTest.java
          http://jenkins-ci.org/commit/mailer-plugin/d54f8d8ed32227c66a9a24a1a31986a19838ce26
          Log:
          Merge pull request #35 from varyvol/JENKINS-41881

          JENKINS-41881 Automated test to cover fix for JENKINS-40224

          Compare: https://github.com/jenkinsci/mailer-plugin/compare/596255227d97...d54f8d8ed322

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/tasks/MailSender.java src/test/java/hudson/tasks/MailerTest.java http://jenkins-ci.org/commit/mailer-plugin/d54f8d8ed32227c66a9a24a1a31986a19838ce26 Log: Merge pull request #35 from varyvol/ JENKINS-41881 JENKINS-41881 Automated test to cover fix for JENKINS-40224 Compare: https://github.com/jenkinsci/mailer-plugin/compare/596255227d97...d54f8d8ed322

            jamesdumay James Dumay
            jeanfred Jean-Frédéric
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: