-
Improvement
-
Resolution: Fixed
-
Minor
-
None
Basically getJnlpMac() does JnlpSlaveAgentProtocol.SLAVE_SECRET.mac(getName()), and EncryptedSlaveAgentJnlpFile.generateResponse does: JnlpSlaveAgentProtocol.SLAVE_SECRET.mac(slaveName.getBytes("UTF-8"))
I'd like to be able to override getJnlpMac and have the key used consistently.
- is related to
-
JENKINS-40413 Create JNLPMacProvider interface and have AccessControlled inherit from it
-
- Open
-
Specifically i think EncryptedSlaveAgentJnlpFile should change it from being an AccessControlled to being a SlaveComputer and the line with JnlpSlaveAgentProtocol.SLAVE_SECRET.mac(slaveName.getBytes("UTF-8")) should become byte[] jnlpMac = Util.fromHexString(it.getJnlpMac())
Thus making the SlaveComputer the one-and-only authority on the secret.