• Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • core

      See attached log and surefire reports directory.

      Failed tests:
        RunTest.getLogReturnsAnRightOrder:192 expected:<[...truncated [6]8 B...]> but was:<[...truncated [7]8 B...]>
        SecretRewriterTest.recursionDetection:100 assert 6==sw.rewriteRecursive(t, st)
              | |  |                |  |
              | |  5                |  hudson.util.StreamTaskListener@19855799
              | |                   C:\workarea\source\github\jenkinsci\temp\jenkins\core\target\junit5825166057877884911\t
              | hudson.util.SecretRewriter@bd09a26
              false
        RunIdMigratorTest.legacy:86 expected:<...otherstuff>
      </run>'}[, 99=?2014-01-02_03-04-05, lastFailedBuild=?-1, lastSuccessfulBuild=?99]}> but was:<...otherstuff>
      </run>'}[]}>
        RunIdMigratorTest.reRunMigration:105 expected:<.../number>
      </run>'}, 9[8=?2014-01-02_03-04-04, 99={build.xml='<?xml version='1.0' encoding='UTF-8'?>
      <run>
        <stuff>ok</stuff>
        <timestamp>1388649845000</timestamp>
        <otherstuff>ok</otherstuff>
      </run>'}, lastFailedBuild=?-1, lastSuccessfulBuild=?99]}> but was:<.../number>
      </run>'}, 9[9={build.xml='<?xml version='1.0' encoding='UTF-8'?>
      <run>
        <stuff>ok</stuff>
        <timestamp>1388649845000</timestamp>
        <otherstuff>ok</otherstuff>
      </run>'}]}>
        RunIdMigratorTest.reverseAfterNewBuilds:129 expected:<{[1=?2014-01-02_03-04-05, ]2014-01-02_03-04-05=...> but was:<{[]2014-01-02_03-04-05=...>
        RunIdMigratorTest.reverseImmediately:117 expected:<...erstuff>
      </run>'}, l[astFailedBuild=?-1, lastSuccessfulBuild=?99, l]egacyIds='2014-01-02...> but was:<...erstuff>
      </run>'}, l[]egacyIds='2014-01-02...>
        RunIdMigratorTest.reverseMatrixAfterNewBuilds:139 expected:<{[1=?2014-01-02_03-04-05, ]2014-01-02_03-04-05=...> but was:<{[]2014-01-02_03-04-05=...>
        RunIdMigratorTest.reverseMavenAfterNewBuilds:149 expected:<{[1=?2014-01-02_03-04-05, ]2014-01-02_03-04-05=...> but was:<{[]2014-01-02_03-04-05=...>
        VirtualFileTest.outsideSymlinks:53
      
      Tests run: 3484, Failures: 9, Errors: 0, Skipped: 9
      

          [JENKINS-40290] unit tests failures in core on windows

          R. Tyler Croy added a comment -

          R. Tyler Croy added a comment - Mmmmm Jenkinsfile https://ci.jenkins.io/job/Core/job/jenkins/

          Daniel Beck added a comment - https://github.com/jenkins-infra/documentation/blob/03ef2277047fd93d8dc882f8c7a0b32dc76fb99e/ci.adoc#node-labels

          James Nord added a comment -

          I ran powershell as an admin (didn't try the part about Local Security Policy yet) and the errors are down to 1

          The tests should have an assumption about symlinks if they require them to pass.
          Not looked at the test but I thought there was a fallback that should work for this situation (unless the test is explicitly testing the symlink bit).

          OT: I'm paranoid and the MS doc has a big fat warning "Symbolic links can expose security vulnerabilities in applications that aren't designed to handle them" And whilst I am a trusted user, I do not trust all of my applications to do the right thing

          Anyway - thanks for looking into this slide_o_mix

          James Nord added a comment - I ran powershell as an admin (didn't try the part about Local Security Policy yet) and the errors are down to 1 The tests should have an assumption about symlinks if they require them to pass. Not looked at the test but I thought there was a fallback that should work for this situation (unless the test is explicitly testing the symlink bit). OT: I'm paranoid and the MS doc has a big fat warning "Symbolic links can expose security vulnerabilities in applications that aren't designed to handle them" And whilst I am a trusted user, I do not trust all of my applications to do the right thing Anyway - thanks for looking into this slide_o_mix

          Filed https://github.com/jenkinsci/jenkins/pull/2689 against the Jenkinsfile to also build the core on Windows.

          Baptiste Mathus added a comment - Filed https://github.com/jenkinsci/jenkins/pull/2689 against the Jenkinsfile to also build the core on Windows.

          teilo Working on ^ I saw there's actually a few failures in the test module of the core. Can you run it too and confirm? (I'm saying "a few" because 60+ is quite high, but still small compared to 9173 ).
          Thanks

          19:03:20 [windows] Tests run: 9173, Failures: 53, Errors: 11, Skipped: 34, Flakes: 3
          19:03:20 [windows] 
          19:03:20 [windows] [ERROR] There are test failures.
          

          Baptiste Mathus added a comment - teilo Working on ^ I saw there's actually a few failures in the test module of the core. Can you run it too and confirm? (I'm saying "a few" because 60+ is quite high, but still small compared to 9173 ). Thanks 19:03:20 [windows] Tests run: 9173, Failures: 53, Errors: 11, Skipped: 34, Flakes: 3 19:03:20 [windows] 19:03:20 [windows] [ERROR] There are test failures.

          Created JENKINS-40746 to followup on the failures on that module and not mix discussions (though there's still probably a link).

          Baptiste Mathus added a comment - Created JENKINS-40746 to followup on the failures on that module and not mix discussions (though there's still probably a link).

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/test/java/hudson/model/RunTest.java
          http://jenkins-ci.org/commit/jenkins/5483ee13833bb44ff611e8da3a8c74379ba26e11
          Log:
          Merge pull request #2690 from batmat/fix-windows-build

          JENKINS-40290 Fix test failing on Windows because of line feed assumption

          Compare: https://github.com/jenkinsci/jenkins/compare/6f9837683905...5483ee13833b

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/test/java/hudson/model/RunTest.java http://jenkins-ci.org/commit/jenkins/5483ee13833bb44ff611e8da3a8c74379ba26e11 Log: Merge pull request #2690 from batmat/fix-windows-build JENKINS-40290 Fix test failing on Windows because of line feed assumption Compare: https://github.com/jenkinsci/jenkins/compare/6f9837683905...5483ee13833b

          James Nord added a comment -

          @batmat not when I ran it (but make sure you use -Dconcurrency=1 otherwise you have a whole slew of random garbage JENKINS-37177)

          I will run again.

          James Nord added a comment - @batmat not when I ran it (but make sure you use -Dconcurrency=1 otherwise you have a whole slew of random garbage JENKINS-37177 ) I will run again.

          Alex Earl added a comment -

          Hasn't this been resolved now?

          Alex Earl added a comment - Hasn't this been resolved now?

          James Nord added a comment -

          slide_o_mix a lot of the tests where "fixed" by ignoring them on windows. https://ci.jenkins.io/job/Core/job/jenkins/job/master/510/testReport/hudson.model/JobTest/testDoNotAutoTrimExistingUntrimmedNames/

          So in one way yes the tests no longer fail - but in another way no - no as there are currently 103 skipped tests and I would guess a large proportion of them are assumeFalse("not on windows" , Functions.isWindows())

          James Nord added a comment - slide_o_mix a lot of the tests where "fixed" by ignoring them on windows. https://ci.jenkins.io/job/Core/job/jenkins/job/master/510/testReport/hudson.model/JobTest/testDoNotAutoTrimExistingUntrimmedNames/ So in one way yes the tests no longer fail - but in another way no - no as there are currently 103 skipped tests and I would guess a large proportion of them are assumeFalse("not on windows" , Functions.isWindows())

            Unassigned Unassigned
            teilo James Nord
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated: