Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40332

Useless context for snippet generator in MBPL folder

XMLWordPrintable

      When accessing a multi-branch pipeline's snippet generator, the context is the multibranch folder, not an individual pipeline job.

      This results in the triggers section for prooperties to have the folder's triggers, which are misleading to pipeline creators.

      This should show a branch pipeline's applicable triggers instead.

      Use case (i.e. "why not just access the branch project?"):
      Access to MBPL snippet generator before having Jenkinsfiles. Sort of a chicken/egg problem.

          [JENKINS-40332] Useless context for snippet generator in MBPL folder

          Daniel Beck created issue -
          Daniel Beck made changes -
          Epic Link New: JENKINS-35393 [ 171186 ]

          Daniel Beck added a comment -

          Came up in https://botbot.me/freenode/jenkins/2016-12-08/?msg=77693236&page=8 until https://botbot.me/freenode/jenkins/2016-12-08/?msg=77694239&page=9

          Daniel Beck added a comment - Came up in https://botbot.me/freenode/jenkins/2016-12-08/?msg=77693236&page=8 until https://botbot.me/freenode/jenkins/2016-12-08/?msg=77694239&page=9

          Stephen Connolly added a comment -

          jglick FYI

          Stephen Connolly added a comment - jglick FYI

          Jesse Glick added a comment -

          Indeed.

          At a minimum, PipelineTriggersJobProperty/config.jelly needs to ignore an it which is not in fact a Job, to avoid offering unusable properties. CC abayer.

          Ideally from the folder, we would show triggers applicable to WorkflowJob. Unfortunately this is impossible using current core APIs: TriggerDescriptor.isApplicable takes an Item not a Class<? extends Item>. We could inspect the type parameter of the Trigger (klazz), though this is less precise.

          If there is already at least one branch project, we could try to redirect to its pipeline-syntax/ page.

          Jesse Glick added a comment - Indeed. At a minimum, PipelineTriggersJobProperty/config.jelly needs to ignore an it which is not in fact a Job , to avoid offering unusable properties. CC abayer . Ideally from the folder, we would show triggers applicable to WorkflowJob . Unfortunately this is impossible using current core APIs: TriggerDescriptor.isApplicable takes an Item not a Class<? extends Item> . We could inspect the type parameter of the Trigger ( klazz ), though this is less precise. If there is already at least one branch project, we could try to redirect to its pipeline-syntax/ page.
          Jesse Glick made changes -
          Component/s New: core [ 15593 ]
          Component/s New: workflow-job-plugin [ 21716 ]
          Component/s Original: pipeline [ 21692 ]
          Labels Original: multibranch New: api pipeline trigger
          Jesse Glick made changes -
          Link New: This issue relates to JENKINS-46286 [ JENKINS-46286 ]
          Andrew Bayer made changes -
          Labels Original: api pipeline trigger New: api pipeline triaged-2018-11 trigger
          Andrew Bayer made changes -
          Assignee New: Andrew Bayer [ abayer ]
          Andrew Bayer made changes -
          Assignee Original: Andrew Bayer [ abayer ]

            Unassigned Unassigned
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: