Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40376

Build must fail, if branch spec is an empty string

    • Icon: Bug Bug
    • Resolution: Won't Fix
    • Icon: Major Major
    • git-plugin
    • None
    • git-plugin version 3.0.1
      jenkins 2.7.4

      Use case:

      Create a freestyle build project with the following settings:

      • This build is parameterized
        Name = BRANCH_SPECIFIER
        Default Value = <leave blank>
        Source Code Management
        Git
      • Branch Specifier (blank for default): = $BRANCH_SPECIFIER

      Expected:
      The build must fail with ERROR because of $BRANCH_SPECIFIER was set as empty and explicit better then implicit. If you want branch spec as "*", then you should set $BRANCH_SPECIFIER was set as "*".

      Actually:
      $BRANCH_SPECIFIER was set as "**" and job will start in an infinite loop. Build for the build.

      Changes inserted in JENKINS-8656 need to be rolled back because they is non logical and misleading.
      Commit https://github.com/jenkinsci/git-plugin/commit/dc575dce269020afe79bf0224c906b2520c5438d

          [JENKINS-40376] Build must fail, if branch spec is an empty string

          Nikolay Ustinov created issue -
          Nikolay Ustinov made changes -
          Link New: This issue is blocked by JENKINS-8656 [ JENKINS-8656 ]
          Nikolay Ustinov made changes -
          Description Original: Use case:
          {quote}
          Create a freestyle build project with the following settings:
          - This build is parameterized
          Name = BRANCH_SPECIFIER
          Default Value = <leave blank>
          Source Code Management
          Git
          - Branch Specifier (blank for default): = $BRANCH_SPECIFIER
          {quote}

          Expected:
          The build must fail with ERROR because of $BRANCH_SPECIFIER was set as empty and *explicit better then implicit*. If you want branch spec as "**", then you should set $BRANCH_SPECIFIER was set as "**".

          Actually:
          $BRANCH_SPECIFIER was set as "**" and job will start in an infinite loop. Build for the build.

          Changes inserted in JENKINS-8656 need to be rolled back because they is non logical and misleading.
          New: Use case:
          {quote}
          Create a freestyle build project with the following settings:
          - This build is parameterized
          Name = BRANCH_SPECIFIER
          Default Value = <leave blank>
          Source Code Management
          Git
          - Branch Specifier (blank for default): = $BRANCH_SPECIFIER
          {quote}

          Expected:
          The build must fail with ERROR because of $BRANCH_SPECIFIER was set as empty and *explicit better then implicit*. If you want branch spec as "**", then you should set $BRANCH_SPECIFIER was set as "**".

          Actually:
          $BRANCH_SPECIFIER was set as "**" and job will start in an infinite loop. Build for the build.

          Changes inserted in JENKINS-8656 need to be rolled back because they is non logical and misleading.
          Commit https://github.com/jenkinsci/git-plugin/commit/dc575dce269020afe79bf0224c906b2520c5438d
          Mark Waite made changes -
          Resolution New: Won't Fix [ 2 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Mark Waite made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]

            markewaite Mark Waite
            sh0ked Nikolay Ustinov
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: