Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4043

can't link to viewvc installation that doesn't end with "viewvc"

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • viewVC-plugin
    • None
    • Platform: All, OS: All

      I have a viewvc installation at http://www.example.com/cgi-bin/viewvc.cgi as its
      root.The current implementation only allows setting the hostname and path, not
      the script name. So when I use the above as url, the plugin sends me to
      http://www.example.com/cgi-bin/viewvc.cgi/viewvc which doesn't exist.

      I suggest that the configuration uses the full url and doesn't append "/viewvc".
      Backwards compatibility might pose a problem, but that could be remedied by
      appending "/viewvc" to the url on upgrading.

        1. HUDSON-4043.patch
          3 kB

          [JENKINS-4043] can't link to viewvc installation that doesn't end with "viewvc"

          Matthew Buckett added a comment -

          Patch that allows the user to specify the full URL for viewvc. It should also migrate existing installations correctly.

          Matthew Buckett added a comment - Patch that allows the user to specify the full URL for viewvc. It should also migrate existing installations correctly.

          wvengen added a comment -

          Just tested in Hudson 1.350 and I can now specify the full url. Thanks!

          wvengen added a comment - Just tested in Hudson 1.350 and I can now specify the full url. Thanks!

          Christopher Tarento added a comment -

          does not work in 1.445

          Christopher Tarento added a comment - does not work in 1.445

          Michael Rumpf added a comment -

          Works in 1.506. Pull request has been sent: https://github.com/jenkinsci/viewVC-plugin/pull/2

          Michael Rumpf added a comment - Works in 1.506. Pull request has been sent: https://github.com/jenkinsci/viewVC-plugin/pull/2

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: mrumpf
          Path:
          src/main/java/hudson/plugins/viewVC/ViewVCRepositoryBrowser.java
          http://jenkins-ci.org/commit/viewVC-plugin/7f5d0c24284ce961dad4a3f1ea0489f354eefaf0
          Log:
          Applied the patch from JENKINS-4043.
          The patch adds the /viewvc/ suffix for all existing ViewVC configurations.
          For new jobs the suffix is not added anymore.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: mrumpf Path: src/main/java/hudson/plugins/viewVC/ViewVCRepositoryBrowser.java http://jenkins-ci.org/commit/viewVC-plugin/7f5d0c24284ce961dad4a3f1ea0489f354eefaf0 Log: Applied the patch from JENKINS-4043 . The patch adds the /viewvc/ suffix for all existing ViewVC configurations. For new jobs the suffix is not added anymore.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michael Rumpf
          Path:
          src/main/java/hudson/plugins/viewVC/ViewVCRepositoryBrowser.java
          http://jenkins-ci.org/commit/viewVC-plugin/0bb9bfd07edf2a63ca590d66b01f8189d8e4b263
          Log:
          Merge pull request #2 from mrumpf/master

          Fix for JENKINS-4043

          Compare: https://github.com/jenkinsci/viewVC-plugin/compare/d6e5af1abca1...0bb9bfd07edf

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michael Rumpf Path: src/main/java/hudson/plugins/viewVC/ViewVCRepositoryBrowser.java http://jenkins-ci.org/commit/viewVC-plugin/0bb9bfd07edf2a63ca590d66b01f8189d8e4b263 Log: Merge pull request #2 from mrumpf/master Fix for JENKINS-4043 Compare: https://github.com/jenkinsci/viewVC-plugin/compare/d6e5af1abca1...0bb9bfd07edf

          Duc Quoc added a comment -

          The merge works well and I can use ViewVC with /viewvc.cgi successfully in 1.6 .
          I think this can be closed.

          However, the links generated per file (for diff/view) is not correct : JENKINS-18283 , which I opened a pull request: https://github.com/jenkinsci/viewVC-plugin/pull/4

          Duc Quoc added a comment - The merge works well and I can use ViewVC with /viewvc.cgi successfully in 1.6 . I think this can be closed. However, the links generated per file (for diff/view) is not correct : JENKINS-18283 , which I opened a pull request: https://github.com/jenkinsci/viewVC-plugin/pull/4

            mirumpf Michael Rumpf
            wvengen wvengen
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: