Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40636

Maven steps enable deprecated injectBuildVariables option

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • job-dsl-plugin
    • None

      From maven-integration-plugin:

      Inject build variables

      Pass all build variables into maven process in form of java properties. This is seldom needed as Jenkins provides it as environment variables anyway. Preferred way to access Jenkins build variables is to explicitly map it to property in Properties section (MY_VAR=${MY_VAR}).

      The DSL Maven step enables this by default. There is no direct way to disable it, one has to go with

      				maven{
      // ...
      					configure { it / injectBuildVariables << false }
      				}

      It would be great to change the default to false,but this will break backwards compatibility.
      If above is not possible at least adding a direct property/method would be nice so that it can be disabled by

      				maven{
      // ...
      					injectBuildVariables false 
      				}

          [JENKINS-40636] Maven steps enable deprecated injectBuildVariables option

          Code changed in jenkins
          User: Daniel Spilker
          Path:
          docs/Home.md
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobManagement.groovy
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/MockJobManagement.groovy
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/RequiresCore.java
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/MavenContext.groovy
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/StepContext.groovy
          job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/CoreVersionASTTransformationSpec.groovy
          job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/step/StepContextSpec.groovy
          job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/InterruptibleJobManagement.groovy
          job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsJobManagement.java
          http://jenkins-ci.org/commit/job-dsl-plugin/384c836962582d3bd2654e0e589016b3e284cbf1
          Log:
          enhanced support for the Maven build step

          [FIXES JENKINS-40636]

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: docs/Home.md job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobManagement.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/MockJobManagement.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/RequiresCore.java job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/MavenContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/StepContext.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/CoreVersionASTTransformationSpec.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/step/StepContextSpec.groovy job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/InterruptibleJobManagement.groovy job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsJobManagement.java http://jenkins-ci.org/commit/job-dsl-plugin/384c836962582d3bd2654e0e589016b3e284cbf1 Log: enhanced support for the Maven build step [FIXES JENKINS-40636]

          Code changed in jenkins
          User: Daniel Spilker
          Path:
          docs/Home.md
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobManagement.groovy
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/MockJobManagement.groovy
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/RequiresCore.java
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/MavenContext.groovy
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/StepContext.groovy
          job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/CoreVersionASTTransformationSpec.groovy
          job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/step/StepContextSpec.groovy
          job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/InterruptibleJobManagement.groovy
          job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsJobManagement.java
          http://jenkins-ci.org/commit/job-dsl-plugin/ab0748a0b08c86b9519ebca2f5c6aefe6aa7820a
          Log:
          Merge pull request #975 from daspilker/JENKINS-40636

          JENKINS-40636 enhanced support for the Maven build step

          Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/86131780161c...ab0748a0b08c

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: docs/Home.md job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobManagement.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/MockJobManagement.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/RequiresCore.java job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/MavenContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/StepContext.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/CoreVersionASTTransformationSpec.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/step/StepContextSpec.groovy job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/InterruptibleJobManagement.groovy job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsJobManagement.java http://jenkins-ci.org/commit/job-dsl-plugin/ab0748a0b08c86b9519ebca2f5c6aefe6aa7820a Log: Merge pull request #975 from daspilker/ JENKINS-40636 JENKINS-40636 enhanced support for the Maven build step Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/86131780161c...ab0748a0b08c

            daspilker Daniel Spilker
            jbochenski Jakub Bochenski
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: