• 2.343

      It would be nice if the Jenkins startup log for permanent slaves would output what protocols it was using to communicate with the master.

      Current behavior

      Right now the startup log looks something like:

      JNLP agent connected from localhost/127.0.0.1
      Slave.jar version: 3.3
      This is a Unix agent
      NOTE: Relative remote path resolved to: /home/sam/sandbox/jenkins
      Agent successfully connected and online
      

      Desired output

      Underneath Slave.jar version would be a good place to output the communication protocol. Something along the lines of:

      JNLP agent connected from localhost/127.0.0.1
      Slave.jar version: 3.3
      Communication Protocol: Java Web Start Agent Protocol/4
      This is a Unix agent
      NOTE: Relative remote path resolved to: /home/sam/sandbox/jenkins
      Agent successfully connected and online
      

      Using the protocol getDisplayName() method.

          [JENKINS-40700] Display communication protocol in agent logs

          Sam Gleske added a comment -

          I opened https://github.com/jenkinsci/jenkins/pull/2682 to enhance the descriptions from the protocol getDisplayName().

          Sam Gleske added a comment - I opened https://github.com/jenkinsci/jenkins/pull/2682 to enhance the descriptions from the protocol getDisplayName() .

          Oleg Nenashev added a comment -

          Added to my backlog

          Oleg Nenashev added a comment - Added to my backlog

          Sam Gleske added a comment -

          PR 2682 doesn't quite address the debugging output. However, it sets us up to be able to use the displayName() method of the protocols to display the communication protocol in the agent logs.

          Sam Gleske added a comment - PR 2682 doesn't quite address the debugging output. However, it sets us up to be able to use the displayName() method of the protocols to display the communication protocol in the agent logs.

          Code changed in jenkins
          User: Sam Gleske
          Path:
          core/src/main/resources/hudson/cli/CliProtocol/description.jelly
          core/src/main/resources/hudson/cli/CliProtocol2/description.jelly
          core/src/main/resources/hudson/cli/Messages.properties
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol/description.jelly
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol2/description.jelly
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol3/description.jelly
          core/src/main/resources/jenkins/slaves/Messages.properties
          http://jenkins-ci.org/commit/jenkins/5f67d909babcdfd220ae8898c398e6f771aca63d
          Log:
          JENKINS-40700 Enhance slave protocol descriptions

          Relates to JENKINS-40700. The updated displayNames describe the
          protocols by using similar verbiage from:

          core/src/main/resources/hudson/cli/CliProtocol/description.jelly
          core/src/main/resources/hudson/cli/CliProtocol2/description.jelly
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol/description.jelly
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol2/description.jelly
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol3/description.jelly
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol4/description.jelly

          At a high level, I wanted to expose to the user, from a security
          perspective, whether or not the protocols were secure and how.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Gleske Path: core/src/main/resources/hudson/cli/CliProtocol/description.jelly core/src/main/resources/hudson/cli/CliProtocol2/description.jelly core/src/main/resources/hudson/cli/Messages.properties core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol/description.jelly core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol2/description.jelly core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol3/description.jelly core/src/main/resources/jenkins/slaves/Messages.properties http://jenkins-ci.org/commit/jenkins/5f67d909babcdfd220ae8898c398e6f771aca63d Log: JENKINS-40700 Enhance slave protocol descriptions Relates to JENKINS-40700 . The updated displayNames describe the protocols by using similar verbiage from: core/src/main/resources/hudson/cli/CliProtocol/description.jelly core/src/main/resources/hudson/cli/CliProtocol2/description.jelly core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol/description.jelly core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol2/description.jelly core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol3/description.jelly core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol4/description.jelly At a high level, I wanted to expose to the user, from a security perspective, whether or not the protocols were secure and how.

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/resources/hudson/cli/CliProtocol/description.jelly
          core/src/main/resources/hudson/cli/CliProtocol/description.properties
          core/src/main/resources/hudson/cli/CliProtocol2/description.jelly
          core/src/main/resources/hudson/cli/CliProtocol2/description.properties
          core/src/main/resources/hudson/cli/Messages.properties
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol/description.jelly
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol/description.properties
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol/description_sr.properties
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol2/description.jelly
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol2/description.properties
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol2/description_sr.properties
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol3/description.jelly
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol3/description.properties
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol3/description_sr.properties
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol4/description.jelly
          core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol4/description.properties
          core/src/main/resources/jenkins/slaves/Messages.properties
          http://jenkins-ci.org/commit/jenkins/0c991dec38800adabacd8a56349bd61575c1d7e5
          Log:
          Merge pull request #2682 from samrocketman/enhance-slave-protocol-descriptions

          JENKINS-40700 Enhance slave protocol descriptions

          Compare: https://github.com/jenkinsci/jenkins/compare/8820a55dc670...0c991dec3880

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/resources/hudson/cli/CliProtocol/description.jelly core/src/main/resources/hudson/cli/CliProtocol/description.properties core/src/main/resources/hudson/cli/CliProtocol2/description.jelly core/src/main/resources/hudson/cli/CliProtocol2/description.properties core/src/main/resources/hudson/cli/Messages.properties core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol/description.jelly core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol/description.properties core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol/description_sr.properties core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol2/description.jelly core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol2/description.properties core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol2/description_sr.properties core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol3/description.jelly core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol3/description.properties core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol3/description_sr.properties core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol4/description.jelly core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol4/description.properties core/src/main/resources/jenkins/slaves/Messages.properties http://jenkins-ci.org/commit/jenkins/0c991dec38800adabacd8a56349bd61575c1d7e5 Log: Merge pull request #2682 from samrocketman/enhance-slave-protocol-descriptions JENKINS-40700 Enhance slave protocol descriptions Compare: https://github.com/jenkinsci/jenkins/compare/8820a55dc670...0c991dec3880

          Hi oleg_nenashev, I see some actions have been taken on this issue but it's still Opened. Can you please let us know what's the latest on it? Is there a plan to fix it or it'll get closed without resolution?

          Thanks,
          Marko

          Marko Andrijevic added a comment - Hi oleg_nenashev , I see some actions have been taken on this issue but it's still Opened. Can you please let us know what's the latest on it? Is there a plan to fix it or it'll get closed without resolution? Thanks, Marko

          Oleg Nenashev added a comment -

          marko_andrijevic I have a plan to work on logging stories once I get bits in JENKINS-44108 landed

          Oleg Nenashev added a comment - marko_andrijevic I have a plan to work on logging stories once I get bits in JENKINS-44108 landed

          Oleg Nenashev added a comment -

          But you can create a pull request, this change is pretty trivial. If there is a PR, I will try to review and integrate it ASAP

          Oleg Nenashev added a comment - But you can create a pull request, this change is pretty trivial. If there is a PR, I will try to review and integrate it ASAP

          Li Ke added a comment -

          oleg_nenashev I can work on this. Just want to know, where can I find the protocol variable. Thanks.

          Li Ke added a comment - oleg_nenashev I can work on this. Just want to know, where can I find the protocol variable. Thanks.

            aki7m Akihiro
            sag47 Sam Gleske
            Votes:
            2 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: