Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40740

Blue ocean branches page crashes when branch does not have a last run date

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • blueocean-plugin
    • jenkins 2.32.1
      blue ocean 1.0.0-b14
    • tethys, pannonian

      When opening the branches view of blue ocean, the page will not render throwing a javascript error if a branch does not have a last run date set: 

      jenkins-js-extension.js:31756 Uncaught TypeError: Cannot read property 'id' of null
    at Branches.render (jenkins-js-extension.js:31756)
    at Object.allowStateChanges (jenkins-js-extension.js:11157)
    at Reaction.<anonymous> (jenkins-js-extension.js:9174)
    at trackDerivedFunction (jenkins-js-extension.js:11424)
    at Reaction.track (jenkins-js-extension.js:11753)
    at reactiveRender (jenkins-js-extension.js:9170)
    at Branches.initialRender (jenkins-js-extension.js:9164)
    at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (blueocean.js:81115)
    at ReactCompositeComponentWrapper._renderValidatedComponent (blueocean.js:81138)
    at ReactCompositeComponentWrapper.performInitialMount (blueocean.js:80680)

      See attached screen capture of debugger console:

        1. image-2016-12-31-10-02-50-882.png
          image-2016-12-31-10-02-50-882.png
          488 kB

          [JENKINS-40740] Blue ocean branches page crashes when branch does not have a last run date

          James Dumay added a comment -

          Thanks for reporting jredl

          James Dumay added a comment - Thanks for reporting jredl

          Ivan Meredith added a comment -

          brody How should the branches display if there is no run for a branch?

          Ivan Meredith added a comment - brody How should the branches display if there is no run for a branch?

          Michael Neale added a comment -

          imeredith - there is an empty state for running non multibranch - I expect it could be reused as is (no mention of branches etc). The empty states may have a new design though.

          Michael Neale added a comment - imeredith - there is an empty state for running non multibranch - I expect it could be reused as is (no mention of branches etc). The empty states may have a new design though.

          Ivan Meredith added a comment -

          michaelneale This has nothing to do with empty state. Its that run data is missing for a branch.

          Ivan Meredith added a comment - michaelneale This has nothing to do with empty state. Its that run data is missing for a branch.

          Brody Maclean added a comment -

          imeredith Is this the same as https://issues.jenkins-ci.org/browse/JENKINS-41238 ?

          Brody Maclean added a comment - imeredith Is this the same as https://issues.jenkins-ci.org/browse/JENKINS-41238 ?

          Oleg Korsak added a comment -

          Got same problem

          Oleg Korsak added a comment - Got same problem

          James Dumay added a comment -

          Thanks Oleg please bear with us while we get the right fixes out

          James Dumay added a comment - Thanks Oleg please bear with us while we get the right fixes out

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ivan Meredith
          Path:
          src/main/js/custom_commands/waitForElementVisibleThenClick.js
          src/test/js/multibranch/noRunsActivityPage.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/ec10c43315cc76d9d75e37baab3f885766749ded
          Log:
          JENKINS-40740 Ath tets to cover missing run data

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ivan Meredith Path: src/main/js/custom_commands/waitForElementVisibleThenClick.js src/test/js/multibranch/noRunsActivityPage.js http://jenkins-ci.org/commit/blueocean-acceptance-test/ec10c43315cc76d9d75e37baab3f885766749ded Log: JENKINS-40740 Ath tets to cover missing run data

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ivan Meredith
          Path:
          src/main/js/custom_commands/waitForElementVisibleThenClick.js
          src/test/js/multibranch/noRunsActivityPage.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/116bcf2714bca556fd09102cfd74a3fc1ef144ed
          Log:
          JENKINS-40740 Ath tests to cover missing run data (#106)

          • More descriptive labels

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ivan Meredith Path: src/main/js/custom_commands/waitForElementVisibleThenClick.js src/test/js/multibranch/noRunsActivityPage.js http://jenkins-ci.org/commit/blueocean-acceptance-test/116bcf2714bca556fd09102cfd74a3fc1ef144ed Log: JENKINS-40740 Ath tests to cover missing run data (#106) JENKINS-40740 Ath tets to cover missing run data More descriptive labels

            imeredith Ivan Meredith
            jredl Jesse Redl
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: