Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40912

Add verbose option to stash/unstash to get list of files

XMLWordPrintable

    • Pipeline - October, Pipeline - April 2018

      It would be great if we could get more info on stash/unstash so I could see a list of files included. I was recently hit by an apparent unstashing hiccup where 1 file that should have been unstashed was not actually there and it made the subsequent errors rather confusing.

      Had there been a list of files in the log that were successfully unstashed then it would have been more clear what the problem was. Perhaps there could even be a validation step to go with this where if the number of files unstashed doesnt match number of stashed files then it logs an error.

          [JENKINS-40912] Add verbose option to stash/unstash to get list of files

          Sparkle Pony created issue -

          Borja Domínguez added a comment -

          I have the same problem, in my case one particular file not being stashed and it's really hard to see that without more info.

          Borja Domínguez added a comment - I have the same problem, in my case one particular file not being stashed and it's really hard to see that without more info.
          Jesse Glick made changes -
          Component/s New: workflow-basic-steps-plugin [ 21712 ]
          James Dumay made changes -
          Labels Original: stash New: cloudbees-internal-pipeline stash
          Michael Neale made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]
          James Dumay made changes -
          Sprint New: Pipeline - Candidates [ 381 ]
          Priority Original: Major [ 3 ] New: Minor [ 4 ]
          Michael Neale made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]

          Michael Neale added a comment - - edited

          The only place I can see to reliably have this is: 

           

          https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/util/io/TarArchiver.java#L62

          https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/util/io/TarArchiver.java#L85

           

          which is deep in the core, this would not be a small change based on that, I can't see another way. 

           

          well in LOC it may be small, but it seems risky to put in core, but the visitor seems to be the place to add logging of items. 

          Similar for unstashing. Ideally we want it to happen as they are fed into or out of the tar archive, to be sure that what is packed is really there (vs just re-listing the filesystem, which people could already do). 

          Michael Neale added a comment - - edited The only place I can see to reliably have this is:    https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/util/io/TarArchiver.java#L62 https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/util/io/TarArchiver.java#L85   which is deep in the core, this would not be a small change based on that, I can't see another way.    well in LOC it may be small, but it seems risky to put in core, but the visitor seems to be the place to add logging of items.  Similar for unstashing. Ideally we want it to happen as they are fed into or out of the tar archive, to be sure that what is packed is really there (vs just re-listing the filesystem, which people could already do). 
          Michael Neale made changes -
          Assignee New: Andrew Bayer [ abayer ]
          James Dumay made changes -
          Sprint Original: Pipeline - Candidates [ 381 ] New: Pipeline - October [ 406 ]
          James Dumay made changes -
          Rank New: Ranked lower

            jtaboada Jose Blas Camacho Taboada
            sparklepony Sparkle Pony
            Votes:
            14 Vote for this issue
            Watchers:
            18 Start watching this issue

              Created:
              Updated: