Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40917

PipelinePage component should check the job type and make sure it's an AbstractPipelineImpl impl

    XMLWordPrintable

Details

    Description

      dashboard:PipelinePage.jsx needs to perform an additional check on the pipeline instance returned from this.context.pipelineService.getPipeline(this.href) inside the render function. It needs to make sure that the _class is not an AbstractPipelineImpl impl it returns a <NotFound /> page, otherwise the user ends up on a weird blank pipeline activity page.

      Attachments

        Issue Links

          is related to

          Task - A task that needs to be done. JENKINS-39842 Open Blue Ocean button should not try to load /activity for a folder

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            tfennelly Tom FENNELLY added a comment -

            This was seen on JENKINS-39842, which is now fixed, so setting the priority to low.

            tfennelly Tom FENNELLY added a comment - This was seen on JENKINS-39842 , which is now fixed, so setting the priority to low.
            cliffmeyers Cliff Meyers added a comment -

            We probably don't want to perform a specific `_class` check and instead rely on `_capabilities` if possible. Perhaps show NotFound if the "pipeline" returned is a folder.

            cliffmeyers Cliff Meyers added a comment - We probably don't want to perform a specific `_class` check and instead rely on `_capabilities` if possible. Perhaps show NotFound if the "pipeline" returned is a folder.
            tfennelly Tom FENNELLY added a comment -

            cliffmeyers obviously. AbstractPipelineImpl would never be returned as the _class since it's abstract. I was meaning to use capabilities (or whatever) to "determine" that the class listed in _class was an AbstractPipelineImpl impl.

            tfennelly Tom FENNELLY added a comment - cliffmeyers obviously. AbstractPipelineImpl would never be returned as the _class since it's abstract. I was meaning to use capabilities (or whatever) to "determine" that the class listed in _class was an AbstractPipelineImpl impl.
            jamesdumay James Dumay added a comment -

            tfennelly was this in the case of matrix projects? We've got some work being done by imeredith that should shore up this area for 1.0

            jamesdumay James Dumay added a comment - tfennelly was this in the case of matrix projects? We've got some work being done by imeredith that should shore up this area for 1.0
            jamesdumay James Dumay added a comment -

            I suspect we don't run into this anymore unless you go directly to a URL

            jamesdumay James Dumay added a comment - I suspect we don't run into this anymore unless you go directly to a URL

            People

              Unassigned Unassigned
              tfennelly Tom FENNELLY
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: