Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41542

Run details changes

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Major Major
    • blueocean-plugin
    • None
    • pannonian, iapetus

      Need to make it look like the zeplin https://zpl.io/2ka0Kn

      • Font weight is incorrect for "Branch" and "Commit"
        • Lacks correct spacing as per mockup
      • Spacing between the Job name and run number is incorrect
      • Spacing / alignment between Branch/Commit labels & span
      • Spacing between icons & spans
      • Alignment of "branch" row and "commit" row
      • Always have to show “Commit: foo", either "Commit: ce87d64" or "Commit: N/A"

        1. App Store #48 2017-01-30 13-29-46.png
          App Store #48 2017-01-30 13-29-46.png
          36 kB
        2. Pasted_Image_1_2_17__3_46_pm.png
          Pasted_Image_1_2_17__3_46_pm.png
          107 kB
        3. screenshot-1.png
          screenshot-1.png
          49 kB

          [JENKINS-41542] Run details changes

          Josh McDonald added a comment -

          <-- Fix long-branch-name also

          Josh McDonald added a comment - <-- Fix long-branch-name also

          Josh McDonald added a comment -

          Note to self: ellipses for long branches, as per JENKINS-41782

          Josh McDonald added a comment - Note to self: ellipses for long branches, as per JENKINS-41782

          Josh McDonald added a comment -

          I'll do what I can about the alignment stuff, but no promises you're going to get pixel-perfection, IIRC it doesn't fit exactly evenly. I mean, I can put things on half-pixels and it'll be sweet on retina, but god help those people on duplo-pixels with IE's text renderer

          Josh McDonald added a comment - I'll do what I can about the alignment stuff, but no promises you're going to get pixel-perfection, IIRC it doesn't fit exactly evenly. I mean, I can put things on half-pixels and it'll be sweet on retina, but god help those people on duplo-pixels with IE's text renderer

          Josh McDonald added a comment -

          More importantly, we're going to have a lot of layouts that can blow out with extension points, so y'all might want to warm up to letting go of a little control

          Josh McDonald added a comment - More importantly, we're going to have a lot of layouts that can blow out with extension points, so y'all might want to warm up to letting go of a little control

          Josh McDonald added a comment -

          https://github.com/jenkinsci/blueocean-plugin/pull/804

          Josh McDonald added a comment - https://github.com/jenkinsci/blueocean-plugin/pull/804

          Josh McDonald added a comment -

          Fixed in master

          Josh McDonald added a comment - Fixed in master

            sophistifunk Josh McDonald
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: