Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41597

Git Creation flow eager validation in UI

    XMLWordPrintable

Details

    Description

      Thanks to the work in JENKINS-41397 we can now detect more errors during the initial REST API call to create a pipeline from Git. We should enhance the UI as follows:

      1. Error 403 w/ code: INVALID and field: scmConfig.credentialId should present an error message related to the selected credential.
      2. Error 400 w/ code: INVALID and field: scmConfig.uri should present an error next to the repository URL field.
      3. Error 403 w/ general message about access denied is probably related to using a URL w/ HTTPS protocol instead of Git. May want to display a more generic error message.

      Attachments

        Issue Links

          duplicates

          Task - A task that needs to be done. JENKINS-42120 Revisit Git repository creation flow credential setup

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved
          is blocked by

          Task - A task that needs to be done. JENKINS-41397 API to validate Git credentials

          • Major - Major loss of function.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-41954 REGRESSION: git repo can no longer be created due to duplicate name error

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            cliffmeyers Cliff Meyers added a comment -

            Not strictly related to this but as suggested by imeredith, perhaps we should also make "Use System SSH" the default selection to simplify things for the user.

            cliffmeyers Cliff Meyers added a comment - Not strictly related to this but as suggested by imeredith , perhaps we should also make "Use System SSH" the default selection to simplify things for the user.
            cliffmeyers Cliff Meyers added a comment -

            Also need to consider how to handle the scenario where there is both a URI / credentials error and a name conflict in a single request. Current UI design isn't great for this.

            cliffmeyers Cliff Meyers added a comment - Also need to consider how to handle the scenario where there is both a URI / credentials error and a name conflict in a single request. Current UI design isn't great for this.
            cliffmeyers Cliff Meyers added a comment -

            NOTE: changes from JENKINS-41397 have not been merged to master. This UI work will need to incorporate this PR / branch: https://github.com/jenkinsci/blueocean-plugin/pull/759

            cliffmeyers Cliff Meyers added a comment - NOTE: changes from JENKINS-41397 have not been merged to master. This UI work will need to incorporate this PR / branch: https://github.com/jenkinsci/blueocean-plugin/pull/759
            jamesdumay James Dumay added a comment -

            imeredith according to cliffmeyers we should fold it into JENKINS-42120.

            jamesdumay James Dumay added a comment - imeredith according to cliffmeyers we should fold it into JENKINS-42120 .

            People

              Unassigned Unassigned
              cliffmeyers Cliff Meyers
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: