Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41609

Dockerfile reuseNode should default argument to true

      See JENKINS-41391. Same idea.

      dockerfile {
          reuseNode()
      }
      

          [JENKINS-41609] Dockerfile reuseNode should default argument to true

          Andrew Bayer added a comment -

          Nope, sorry. We already had this discussion when we added reuseNode - retaining existing behavior is more important.

          Andrew Bayer added a comment - Nope, sorry. We already had this discussion when we added reuseNode - retaining existing behavior is more important.

          Andrew Bayer added a comment -

          whoops, misunderstood

          Andrew Bayer added a comment - whoops, misunderstood

          Andrew Bayer added a comment -

          ...though I'm gonna WONTFIX this too, because reuseNode() would be syntactically different than everything else in agent - it's always foo bar.

          Andrew Bayer added a comment - ...though I'm gonna WONTFIX this too, because reuseNode() would be syntactically different than everything else in agent - it's always foo bar .

          Liam Newman added a comment -

          Would this break the existing behavior?

          Liam Newman added a comment - Would this break the existing behavior?

          Liam Newman added a comment -

          abayer
          In groovy: something else is functionally something(else), right?

          Liam Newman added a comment - abayer In groovy: something else is functionally something(else) , right?

          Andrew Bayer added a comment -

          Yes, those are functionally equivalent. It's the no-args thing that makes things wonky.

          In general, anywhere where I can control the syntax entirely (i.e., not things containing steps, job properties, etc that have their syntax defined outside of Declarative), we go with "key value"-ish syntax. That doesn't work with a no-arg approach, and "key" doesn't work as a method without the parentheses.

          Andrew Bayer added a comment - Yes, those are functionally equivalent. It's the no-args thing that makes things wonky. In general, anywhere where I can control the syntax entirely (i.e., not things containing steps, job properties, etc that have their syntax defined outside of Declarative), we go with "key value"-ish syntax. That doesn't work with a no-arg approach, and "key" doesn't work as a method without the parentheses.

          Liam Newman added a comment -

          So, that would take us back to JENKINS-40721.

          Liam Newman added a comment - So, that would take us back to JENKINS-40721 .

          Andrew Bayer added a comment -

          Yup.

          Andrew Bayer added a comment - Yup.

            Unassigned Unassigned
            bitwiseman Liam Newman
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: