Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41657

workflow-cps-global-lib not compatible with mercurial

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • mercurial-plugin
    • Jenkins 2.32.1
      workflow-cps-global-lib-plugin 2.5
      scm api 1.3
      mercurial plugin 1.57

      I'm trying to use the workflow-cps-global-lib plugin with the mercurial SCM (legacy mode)

      The dropdown to select the credentials for the mercurial checkout of the library doesn't contain the username/password credentials that I have configured globally.

      I tried configuring the credentialsId manually in the org.jenkinsci.plugins.workflow.libs.GlobalLibraries.xml file and "reload from disk" but it seems it was ignored when trying to import the library I get Authentication required.

          [JENKINS-41657] workflow-cps-global-lib not compatible with mercurial

          Jesse Glick added a comment -

          MercurialSCMSource needs to implement retrieveRevisions so you can use “modern” mode. MercurialSCM.DescriptorImpl.doFillCredentialsIdItems also needs to support legacy mode for global (as opposed to folder) libraries.

          Jesse Glick added a comment - MercurialSCMSource needs to implement retrieveRevisions so you can use “modern” mode. MercurialSCM.DescriptorImpl.doFillCredentialsIdItems also needs to support legacy mode for global (as opposed to folder) libraries.

          Manuel Ryan added a comment -

          Created PR #99 in the mercurial plugin to allow filling credential ids from the admin panel (https://github.com/jenkinsci/mercurial-plugin/pull/99)

          Manuel Ryan added a comment - Created PR #99 in the mercurial plugin to allow filling credential ids from the admin panel ( https://github.com/jenkinsci/mercurial-plugin/pull/99 )

          Code changed in jenkins
          User: Manuel Ryan
          Path:
          src/main/java/hudson/plugins/mercurial/MercurialSCM.java
          src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
          src/test/java/hudson/plugins/mercurial/ConfigurationTest.java
          http://jenkins-ci.org/commit/mercurial-plugin/a56bf2d4c4961a0d66bc00e5b1fc637bd6ed12f7
          Log:
          JENKINS-41657 allow filling of credential ids outside of the context of a job, only when ADMINISTER permission is granted

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Ryan Path: src/main/java/hudson/plugins/mercurial/MercurialSCM.java src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java src/test/java/hudson/plugins/mercurial/ConfigurationTest.java http://jenkins-ci.org/commit/mercurial-plugin/a56bf2d4c4961a0d66bc00e5b1fc637bd6ed12f7 Log: JENKINS-41657 allow filling of credential ids outside of the context of a job, only when ADMINISTER permission is granted

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/hudson/plugins/mercurial/MercurialSCM.java
          src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
          src/test/java/hudson/plugins/mercurial/ConfigurationTest.java
          src/test/java/hudson/plugins/mercurial/MercurialSCMSourceTest.java
          http://jenkins-ci.org/commit/mercurial-plugin/0997b9dce5de339d9b2335b9631233b4ae4c0475
          Log:
          Merge pull request #99 from mryan43/master

          JENKINS-41657 Allow filling of credential ids from admin panel

          Compare: https://github.com/jenkinsci/mercurial-plugin/compare/2903930fd367...0997b9dce5de

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/plugins/mercurial/MercurialSCM.java src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java src/test/java/hudson/plugins/mercurial/ConfigurationTest.java src/test/java/hudson/plugins/mercurial/MercurialSCMSourceTest.java http://jenkins-ci.org/commit/mercurial-plugin/0997b9dce5de339d9b2335b9631233b4ae4c0475 Log: Merge pull request #99 from mryan43/master JENKINS-41657 Allow filling of credential ids from admin panel Compare: https://github.com/jenkinsci/mercurial-plugin/compare/2903930fd367...0997b9dce5de

            mryan Manuel Ryan
            mryan Manuel Ryan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: