Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41899

Version Number comparisons are not timestamped -SNAPSHOT aware

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      Version Number comparison is not aware of -20170207.105042-1 style timestamp snapshots.

      As a result, if you install a plugin with timestamp snapshot based dependencies, you cannot start Jenkins because the timestamp of a deployment is generated after the artifact has been built and as such the version will report as -SNAPSHOT which currently reporting as older than the timestamp snapshot.

          [JENKINS-41899] Version Number comparisons are not timestamped -SNAPSHOT aware

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/util/VersionNumber.java
          src/test/java/hudson/util/VersionNumberTest.java
          http://jenkins-ci.org/commit/lib-version-number/d773321cad7be4618e95db82a1b7f28edf4979c5
          Log:
          [FIXED JENKINS-41899] Make VersionNumber timestamped snapshot aware

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/util/VersionNumber.java src/test/java/hudson/util/VersionNumberTest.java http://jenkins-ci.org/commit/lib-version-number/d773321cad7be4618e95db82a1b7f28edf4979c5 Log: [FIXED JENKINS-41899] Make VersionNumber timestamped snapshot aware

          olivergondza https://github.com/jenkinsci/jenkins/pull/2750 is the change that would be awesome to get into the next LTS

          Stephen Connolly added a comment - olivergondza https://github.com/jenkinsci/jenkins/pull/2750 is the change that would be awesome to get into the next LTS

          This seems to affect development/hotfix testing only, right?

          Oliver Gondža added a comment - This seems to affect development/hotfix testing only, right?

          Well if you do not deploy a -SNAPSHOT then this will have no impact.

          If you deploy a -SNAPSHOT (that only has non-SNAPSHOT dependencies) to 2.32.x that will be unaffected also

          If you deploy a -SNAPSHOT that has timestamp SNAPSHOT dependencies to 2.32.x then your instance will not start the plugin making it very difficult for users to evaluate fixes. With this change, users will be able to avail of critical fixes and developers will be able to work on those fixes without having to juggle pom changes back and forth between their PR and what is needed to test locally

          Stephen Connolly added a comment - Well if you do not deploy a -SNAPSHOT then this will have no impact. If you deploy a -SNAPSHOT (that only has non-SNAPSHOT dependencies) to 2.32.x that will be unaffected also If you deploy a -SNAPSHOT that has timestamp SNAPSHOT dependencies to 2.32.x then your instance will not start the plugin making it very difficult for users to evaluate fixes. With this change, users will be able to avail of critical fixes and developers will be able to work on those fixes without having to juggle pom changes back and forth between their PR and what is needed to test locally

          Jesse Glick added a comment -

          Again, does it not suffice to use the 2.22 parent POM?

          Jesse Glick added a comment - Again, does it not suffice to use the 2.22 parent POM?

          jglick if the plugin has been updated to use that parent. There may be plugins where the maintainer does not want to make that change yet

          Stephen Connolly added a comment - jglick if the plugin has been updated to use that parent. There may be plugins where the maintainer does not want to make that change yet

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/pom.xml
          http://jenkins-ci.org/commit/jenkins/5969b8da99cc5541e313cf343cd31ba3ad2e4843
          Log:
          JENKINS-41899 Pick up fix

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/pom.xml http://jenkins-ci.org/commit/jenkins/5969b8da99cc5541e313cf343cd31ba3ad2e4843 Log: JENKINS-41899 Pick up fix

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/pom.xml
          http://jenkins-ci.org/commit/jenkins/079c47a573e556e5593bf29e1d6bec8c70f67b68
          Log:
          Merge pull request #2750 from stephenc/jenkins-41899

          JENKINS-41899 Update version-number dependency to 1.3

          Compare: https://github.com/jenkinsci/jenkins/compare/6342a9b06b71...079c47a573e5

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/pom.xml http://jenkins-ci.org/commit/jenkins/079c47a573e556e5593bf29e1d6bec8c70f67b68 Log: Merge pull request #2750 from stephenc/jenkins-41899 JENKINS-41899 Update version-number dependency to 1.3 Compare: https://github.com/jenkinsci/jenkins/compare/6342a9b06b71...079c47a573e5

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/87add643656e72b89fa7b4187dcbe7ffc65732bc
          Log:
          Noting merge of JENKINS-41899

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: changelog.html http://jenkins-ci.org/commit/jenkins/87add643656e72b89fa7b4187dcbe7ffc65732bc Log: Noting merge of JENKINS-41899

          Fixed towards 2.47

          Stephen Connolly added a comment - Fixed towards 2.47

            stephenconnolly Stephen Connolly
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: