Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41955

MaskPaswordsBuildWrapper no longer hiding Passwords

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: mask-passwords-plugin
    • Labels:
      None
    • Environment:
      Jenkins 2.19.4 and 2.32.4 and Mask Passwords 2.9
    • Similar Issues:

      Description

      The MaskPasswordsBuildWrapper for Pipeline is no longer hiding passwords in Mask Passwords 2.9. Freestyle jobs appear to work. Version 2.8 works correctly.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsConfig.java
          http://jenkins-ci.org/commit/mask-passwords-plugin/391f3a944333dae4dcdb933d05e659d4bd484757
          Log:
          JENKINS-41955 - Introduce checks of all available API methods

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsConfig.java http://jenkins-ci.org/commit/mask-passwords-plugin/391f3a944333dae4dcdb933d05e659d4bd484757 Log: JENKINS-41955 - Introduce checks of all available API methods
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java
          src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsConfig.java
          src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterDefinition.java
          src/test/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterTest.java
          http://jenkins-ci.org/commit/mask-passwords-plugin/ffd1d9b867904937b8e718575b6b5e1b9eb6133b
          Log:
          [JENKINS-25737, JENKINS-41955] - Rework the broken PasswordParameterValue handling approach

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsConfig.java src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterDefinition.java src/test/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterTest.java http://jenkins-ci.org/commit/mask-passwords-plugin/ffd1d9b867904937b8e718575b6b5e1b9eb6133b Log: [JENKINS-25737, JENKINS-41955] - Rework the broken PasswordParameterValue handling approach
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsConfig.java
          src/test/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsURLEncodingTest.java
          src/test/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsWorkflowTest.java
          src/test/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterTest.java
          http://jenkins-ci.org/commit/mask-passwords-plugin/d3d8c23e099f8b503b2af375105f5ffc03fad9c3
          Log:
          JENKINS-25735 JENKINS-41955 - Tests should invalidate caches where possible

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsConfig.java src/test/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsURLEncodingTest.java src/test/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsWorkflowTest.java src/test/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterTest.java http://jenkins-ci.org/commit/mask-passwords-plugin/d3d8c23e099f8b503b2af375105f5ffc03fad9c3 Log: JENKINS-25735 JENKINS-41955 - Tests should invalidate caches where possible
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java
          src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsConfig.java
          src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterDefinition.java
          src/test/java/com/michelin/cio/hudson/plugins/integrations/CorePasswordParameterTest.java
          src/test/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordConfigTests.java
          src/test/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsURLEncodingTest.java
          src/test/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsWorkflowTest.java
          src/test/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterTest.java
          http://jenkins-ci.org/commit/mask-passwords-plugin/bd5f530db9c5275313de247dfd3c8957a88222a6
          Log:
          Merge pull request #12 from oleg-nenashev/JENKINS-25735-41955-mask-passwords

          [JENKINS-25735, JENKINS-41955, etc.] Improve masking of passwords in the plugin

          Compare: https://github.com/jenkinsci/mask-passwords-plugin/compare/93abe61816c3...bd5f530db9c5

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsConfig.java src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterDefinition.java src/test/java/com/michelin/cio/hudson/plugins/integrations/CorePasswordParameterTest.java src/test/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordConfigTests.java src/test/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsURLEncodingTest.java src/test/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsWorkflowTest.java src/test/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterTest.java http://jenkins-ci.org/commit/mask-passwords-plugin/bd5f530db9c5275313de247dfd3c8957a88222a6 Log: Merge pull request #12 from oleg-nenashev/ JENKINS-25735 -41955-mask-passwords [JENKINS-25735, JENKINS-41955, etc.] Improve masking of passwords in the plugin Compare: https://github.com/jenkinsci/mask-passwords-plugin/compare/93abe61816c3...bd5f530db9c5
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Released in 2.10

          Show
          oleg_nenashev Oleg Nenashev added a comment - Released in 2.10

            People

            Assignee:
            oleg_nenashev Oleg Nenashev
            Reporter:
            mbidewel Mark
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: