• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Critical Critical
    • blueocean-plugin
    • None
    • 1.0

      Entry points
      Clicking the edit link on these places launches the Editor against that branch

      • Existing functionality that lets you copy and paste the Jenkinsfile should be preserved as the "degrated" experience.

      Saving

      We present a dialog that allows users to:

      • Specify a commit message
      • Specify a commit description
      • Radio list
        • Commit to $CURRENT_BRANCH
        • Commit to new branch
          • Text box: branch name - only show this text input if "commit to new branch" radio is selected
      • Buttons
        • Save - commits the Jenkinsfile and triggers a rescan
        • Cancel - exists this dialog and returns to the editor

      Design:

      Resolving scopes
      When saving we may have to ask for a "upgrade" to the stored Github token or provide one if the user does not have one set (credentials are stored per user). Writing to the repository also requires different scopes than what we may have setup during creation. I'd imagine this looks very similar to the creation way of doing it (asking for a Key)

          [JENKINS-41966] Load and save Jenkinsfile to Github

          Code changed in jenkins
          User: Keith Zantow
          Path:
          .babelrc
          package.json
          pom.xml
          src/main/js/EditorPage.jsx
          src/main/js/EditorRoutes.jsx
          src/main/js/NewPipelineTemplate.json
          src/main/js/PipelineCreateButton.jsx
          src/main/js/PipelineEditor.jsx
          src/main/js/PipelineEditorLink.jsx
          src/main/js/SaveApi.js
          src/main/js/components/EditorPreview.jsx
          src/main/js/components/editor/AddStepSelectionSheet.jsx
          src/main/js/components/editor/EditorMain.jsx
          src/main/js/components/editor/EditorPage.jsx
          src/main/js/components/editor/EditorStepList.jsx
          src/main/js/components/editor/EnvironmentConfiguration.jsx
          src/main/js/components/editor/NewPipelineTemplate.json
          src/main/js/jenkins-js-extension.yaml
          src/main/js/services/PipelineSyntaxConverter.js
          src/main/js/services/PipelineValidator.js
          src/main/js/services/fetchClassic.js
          src/main/less/editor.less
          src/main/less/extensions.less
          src/main/less/header-buttons.less
          http://jenkins-ci.org/commit/blueocean-pipeline-editor-plugin/8f043b56d4dc1754b7c8bee62bf9761b59ca8b6d
          Log:
          [WiP] [FIX JENKINS-41966] load and save (#29)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Keith Zantow Path: .babelrc package.json pom.xml src/main/js/EditorPage.jsx src/main/js/EditorRoutes.jsx src/main/js/NewPipelineTemplate.json src/main/js/PipelineCreateButton.jsx src/main/js/PipelineEditor.jsx src/main/js/PipelineEditorLink.jsx src/main/js/SaveApi.js src/main/js/components/EditorPreview.jsx src/main/js/components/editor/AddStepSelectionSheet.jsx src/main/js/components/editor/EditorMain.jsx src/main/js/components/editor/EditorPage.jsx src/main/js/components/editor/EditorStepList.jsx src/main/js/components/editor/EnvironmentConfiguration.jsx src/main/js/components/editor/NewPipelineTemplate.json src/main/js/jenkins-js-extension.yaml src/main/js/services/PipelineSyntaxConverter.js src/main/js/services/PipelineValidator.js src/main/js/services/fetchClassic.js src/main/less/editor.less src/main/less/extensions.less src/main/less/header-buttons.less http://jenkins-ci.org/commit/blueocean-pipeline-editor-plugin/8f043b56d4dc1754b7c8bee62bf9761b59ca8b6d Log: [WiP] [FIX JENKINS-41966] load and save (#29) JENKINS-41966 - pieline editor load and save

            kzantow Keith Zantow
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: