• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Critical Critical
    • blueocean-plugin
    • None
    • 1.0

      Entry points
      Clicking the edit link on these places launches the Editor against that branch

      • Existing functionality that lets you copy and paste the Jenkinsfile should be preserved as the "degrated" experience.

      Saving

      We present a dialog that allows users to:

      • Specify a commit message
      • Specify a commit description
      • Radio list
        • Commit to $CURRENT_BRANCH
        • Commit to new branch
          • Text box: branch name - only show this text input if "commit to new branch" radio is selected
      • Buttons
        • Save - commits the Jenkinsfile and triggers a rescan
        • Cancel - exists this dialog and returns to the editor

      Design:

      Resolving scopes
      When saving we may have to ask for a "upgrade" to the stored Github token or provide one if the user does not have one set (credentials are stored per user). Writing to the repository also requires different scopes than what we may have setup during creation. I'd imagine this looks very similar to the creation way of doing it (asking for a Key)

          [JENKINS-41966] Load and save Jenkinsfile to Github

          James Dumay created issue -
          James Dumay made changes -
          Epic Link New: JENKINS-36291 [ 172300 ]
          James Dumay made changes -
          Description Original:
          *Entry points*
          * Creation (when there is no Jenkinsfile in the repository)
          * For a specific branch on the Branches tab
          * For a specific branch on the run screen

          *Saving options*
          Very similar to Githubs web file editing workflow.

          We present a dialog that allows users to:
          * Specify a commit message
          * Specify a commit description
          ** Radio list
          ** Commit to $CURRENT_BRANCH
          ** Commit to new branch
          *** Text box: branch name

          _Github example_
           !github-new-file.png|thumbnail!

          New: *Entry points*
          * Creation (when there is no Jenkinsfile in the repository)
          * For a specific branch on the Branches tab
          * For a specific branch on the run screen

          *Saving options*
          Very similar to Githubs web file editing workflow.

          We present a dialog that allows users to:
          * Specify a commit message
          * Specify a commit description
          ** Radio list
          ** Commit to $CURRENT_BRANCH
          ** Commit to new branch
          *** Text box: branch name
          * Buttons
          ** Save - commits the Jenkinsfile
          ** Cancel - exists this dialog and returns to the editor

          _Github example_
           !github-new-file.png|thumbnail!

          *Editor header buttons*
          * Save - triggers the save dialog
          * Try - *Needs to be defined*
          ** On success there is an option on the run screen to "save" the changes
          * Cancel - exists the editor without saving, goes back to entry point
          James Dumay made changes -
          Description Original: *Entry points*
          * Creation (when there is no Jenkinsfile in the repository)
          * For a specific branch on the Branches tab
          * For a specific branch on the run screen

          *Saving options*
          Very similar to Githubs web file editing workflow.

          We present a dialog that allows users to:
          * Specify a commit message
          * Specify a commit description
          ** Radio list
          ** Commit to $CURRENT_BRANCH
          ** Commit to new branch
          *** Text box: branch name
          * Buttons
          ** Save - commits the Jenkinsfile
          ** Cancel - exists this dialog and returns to the editor

          _Github example_
           !github-new-file.png|thumbnail!

          *Editor header buttons*
          * Save - triggers the save dialog
          * Try - *Needs to be defined*
          ** On success there is an option on the run screen to "save" the changes
          * Cancel - exists the editor without saving, goes back to entry point
          New: *Entry points*
          * Creation (when there is no Jenkinsfile in the repository)
          * For a specific branch on the Branches tab
          * For a specific branch on the run screen

          *Saving options*
          Very similar to Githubs web file editing workflow.

          We present a dialog that allows users to:
          * Specify a commit message
          * Specify a commit description
          ** Radio list
          ** Commit to $CURRENT_BRANCH
          ** Commit to new branch
          *** Text box: branch name
          * Buttons
          ** Save - commits the Jenkinsfile
          ** Cancel - exists this dialog and returns to the editor

          _Github example_
           !github-new-file.png|thumbnail!

          *Editor header buttons*
          * Save - triggers the save dialog
          * Try
          ** Needs to be defined*]
          * Cancel - exists the editor without saving, goes back to entry point
          James Dumay made changes -
          Description Original: *Entry points*
          * Creation (when there is no Jenkinsfile in the repository)
          * For a specific branch on the Branches tab
          * For a specific branch on the run screen

          *Saving options*
          Very similar to Githubs web file editing workflow.

          We present a dialog that allows users to:
          * Specify a commit message
          * Specify a commit description
          ** Radio list
          ** Commit to $CURRENT_BRANCH
          ** Commit to new branch
          *** Text box: branch name
          * Buttons
          ** Save - commits the Jenkinsfile
          ** Cancel - exists this dialog and returns to the editor

          _Github example_
           !github-new-file.png|thumbnail!

          *Editor header buttons*
          * Save - triggers the save dialog
          * Try
          ** Needs to be defined*]
          * Cancel - exists the editor without saving, goes back to entry point
          New: *Entry points*
          * Creation (when there is no Jenkinsfile in the repository)
          * For a specific branch on the Branches tab
          * For a specific branch on the run screen

          *Saving options*
          Very similar to Githubs web file editing workflow.

          We present a dialog that allows users to:
          * Specify a commit message
          * Specify a commit description
          ** Radio list
          ** Commit to $CURRENT_BRANCH
          ** Commit to new branch
          *** Text box: branch name
          * Buttons
          ** Save - commits the Jenkinsfile
          ** Cancel - exists this dialog and returns to the editor

          _Github example_
           !github-new-file.png|thumbnail!

          *Editor header buttons*
          * Save - triggers the save dialog
          * Try
          ** Needs to be defined*
          * Cancel - exists the editor without saving, goes back to entry point
          James Dumay made changes -
          Description Original: *Entry points*
          * Creation (when there is no Jenkinsfile in the repository)
          * For a specific branch on the Branches tab
          * For a specific branch on the run screen

          *Saving options*
          Very similar to Githubs web file editing workflow.

          We present a dialog that allows users to:
          * Specify a commit message
          * Specify a commit description
          ** Radio list
          ** Commit to $CURRENT_BRANCH
          ** Commit to new branch
          *** Text box: branch name
          * Buttons
          ** Save - commits the Jenkinsfile
          ** Cancel - exists this dialog and returns to the editor

          _Github example_
           !github-new-file.png|thumbnail!

          *Editor header buttons*
          * Save - triggers the save dialog
          * Try
          ** Needs to be defined*
          * Cancel - exists the editor without saving, goes back to entry point
          New: *Entry points*
          * Creation (when there is no Jenkinsfile in the repository)
          * For a specific branch on the Branches tab
          * For a specific branch on the run screen

          *Saving options*
          Very similar to Githubs web file editing workflow.

          We present a dialog that allows users to:
          * Specify a commit message
          * Specify a commit description
          * Radio list
          ** Commit to $CURRENT_BRANCH
          ** Commit to new branch
          *** Text box: branch name
          * Buttons
          ** Save - commits the Jenkinsfile
          ** Cancel - exists this dialog and returns to the editor

          _Github example_
           !github-new-file.png|thumbnail!

          *Editor header buttons*
          * Save - triggers the save dialog
          * Try
          ** Needs to be defined*
          * Cancel - exists the editor without saving, goes back to entry point
          James Dumay made changes -
          Link New: This issue relates to JENKINS-39703 [ JENKINS-39703 ]
          James Dumay made changes -
          Description Original: *Entry points*
          * Creation (when there is no Jenkinsfile in the repository)
          * For a specific branch on the Branches tab
          * For a specific branch on the run screen

          *Saving options*
          Very similar to Githubs web file editing workflow.

          We present a dialog that allows users to:
          * Specify a commit message
          * Specify a commit description
          * Radio list
          ** Commit to $CURRENT_BRANCH
          ** Commit to new branch
          *** Text box: branch name
          * Buttons
          ** Save - commits the Jenkinsfile
          ** Cancel - exists this dialog and returns to the editor

          _Github example_
           !github-new-file.png|thumbnail!

          *Editor header buttons*
          * Save - triggers the save dialog
          * Try
          ** Needs to be defined*
          * Cancel - exists the editor without saving, goes back to entry point
          New: *Entry points*
          * Creation (when there is no Jenkinsfile in the repository)
          * For a specific branch on the Branches tab
          * For a specific branch on the run screen

          *Saving options*
          Very similar to Githubs web file editing workflow.

          We present a dialog that allows users to:
          * Specify a commit message
          * Specify a commit description
          * Radio list
          ** Commit to $CURRENT_BRANCH
          ** Commit to new branch
          *** Text box: branch name
          * Buttons
          ** Save - commits the Jenkinsfile
          ** Cancel - exists this dialog and returns to the editor

          _Github example_
           !github-new-file.png|thumbnail!

          When saving we may have to ask for a "upgrade" to the stored Github token. Writing to the repository needs different scopes than what we may have setup during creation.

          *Editor header buttons*
          * Save - triggers the save dialog
          * Try
          ** Needs to be defined*
          * Cancel - exists the editor without saving, goes back to entry point
          James Dumay made changes -
          Description Original: *Entry points*
          * Creation (when there is no Jenkinsfile in the repository)
          * For a specific branch on the Branches tab
          * For a specific branch on the run screen

          *Saving options*
          Very similar to Githubs web file editing workflow.

          We present a dialog that allows users to:
          * Specify a commit message
          * Specify a commit description
          * Radio list
          ** Commit to $CURRENT_BRANCH
          ** Commit to new branch
          *** Text box: branch name
          * Buttons
          ** Save - commits the Jenkinsfile
          ** Cancel - exists this dialog and returns to the editor

          _Github example_
           !github-new-file.png|thumbnail!

          When saving we may have to ask for a "upgrade" to the stored Github token. Writing to the repository needs different scopes than what we may have setup during creation.

          *Editor header buttons*
          * Save - triggers the save dialog
          * Try
          ** Needs to be defined*
          * Cancel - exists the editor without saving, goes back to entry point
          New: *Entry points*
          * Creation (when there is no Jenkinsfile in the repository)
          * For a specific branch on the Branches tab
          * For a specific branch on the run screen

          *Saving options*
          Very similar to Githubs web file editing workflow.

          We present a dialog that allows users to:
          * Specify a commit message
          * Specify a commit description
          * Radio list
          ** Commit to $CURRENT_BRANCH
          ** Commit to new branch
          *** Text box: branch name
          * Buttons
          ** Save - commits the Jenkinsfile
          ** Cancel - exists this dialog and returns to the editor

          _Github example_
           !github-new-file.png|thumbnail!

          *Authenticating*
          When saving we may have to ask for a "upgrade" to the stored Github token. Writing to the repository needs different scopes than what we may have setup during creation.

          *Editor header buttons*
          * Save - triggers the save dialog
          * Try
          ** Needs to be defined*
          * Cancel - exists the editor without saving, goes back to entry point
          James Dumay made changes -
          Description Original: *Entry points*
          * Creation (when there is no Jenkinsfile in the repository)
          * For a specific branch on the Branches tab
          * For a specific branch on the run screen

          *Saving options*
          Very similar to Githubs web file editing workflow.

          We present a dialog that allows users to:
          * Specify a commit message
          * Specify a commit description
          * Radio list
          ** Commit to $CURRENT_BRANCH
          ** Commit to new branch
          *** Text box: branch name
          * Buttons
          ** Save - commits the Jenkinsfile
          ** Cancel - exists this dialog and returns to the editor

          _Github example_
           !github-new-file.png|thumbnail!

          *Authenticating*
          When saving we may have to ask for a "upgrade" to the stored Github token. Writing to the repository needs different scopes than what we may have setup during creation.

          *Editor header buttons*
          * Save - triggers the save dialog
          * Try
          ** Needs to be defined*
          * Cancel - exists the editor without saving, goes back to entry point
          New: *Entry points*
          * Creation (when there is no Jenkinsfile in the repository)
          * For a specific branch on the Branches tab
          * For a specific branch on the run screen

          *Saving options*
          Very similar to Githubs web file editing workflow.

          We present a dialog that allows users to:
          * Specify a commit message
          * Specify a commit description
          * Radio list
          ** Commit to $CURRENT_BRANCH
          ** Commit to new branch
          *** Text box: branch name
          * Buttons
          ** Save - commits the Jenkinsfile
          ** Cancel - exists this dialog and returns to the editor

          _Github example_
           !github-new-file.png|thumbnail!

          *Authenticating*
          When saving we may have to ask for a "upgrade" to the stored Github token. Writing to the repository needs different scopes than what we may have setup during creation. I'd imagine this looks very similar to the creation way of doing it (asking for a Key)

          *Editor header buttons*
          * Save - triggers the save dialog
          * Try
          ** Needs to be defined*
          * Cancel - exists the editor without saving, goes back to entry point
          Brody Maclean made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

            kzantow Keith Zantow
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: