Code changed in jenkins
User: Mark Waite
Path:
pom.xml
http://jenkins-ci.org/commit/git-client-plugin/edc937d54f5001ed97cf74f330a9492c10d5a30f
Log:
Add test dependency on instance-identity
The CredentialsTest was suffering intermittent failures with a report that:
1) Error injecting constructor, java.security.KeyStoreException: JENKINS-41987: no X509Certificate found; perhaps instance-identity module is missing or too old
at jenkins.slaves.JnlpSlaveAgentProtocol4.<init>(JnlpSlaveAgentProtocol4.java:101)
Caused by: java.security.KeyStoreException: JENKINS-41987: no X509Certificate found; perhaps instance-identity module is missing or too old
at jenkins.slaves.JnlpSlaveAgentProtocol4.<init>(JnlpSlaveAgentProtocol4.java:105)
at jenkins.slaves.JnlpSlaveAgentProtocol4$$FastClassByGuice$$b470638c.newInstance(<generated>)
at com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(FastConstructor.java:40)
at com.google.inject.internal.DefaultConstructionProxyFactory$1.newInstance(DefaultConstructionProxyFactory.java:61)
at com.google.inject.internal.ConstructorInjector.provision(ConstructorInjector.java:105)
at com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:85)
at com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:267)
at com.google.inject.internal.ProviderToInternalFactoryAdapter$1.call(ProviderToInternalFactoryAdapter.java:46)
at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1103)
at com.google.inject.internal.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:40)
... 14 more
The most recent versions of instance-identity require a Jenkins 2 base
version. Since this plugin is still based on Jenkins 1.625, it cannot use
the most recent instance-identity. The 1.5.1 release of instance-identity
seems to be the latest version which supports Jenkins 1.625.
Because the failure is intermittent, I'm not yet confident this resolves
the problem. Tests will run on this commit in various environments to
see if it helps.
Compare: https://github.com/jenkinsci/git-client-plugin/compare/1ddecc20011f^...edc937d54f50
Code changed in jenkins
User: Jesse Glick
Path:
core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol4.java
http://jenkins-ci.org/commit/jenkins/dbf5efa6ae60c30d00afca61d3fd24f56f2c860c
Log:
JENKINS-41987Improved message.