Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55582

Convert modules to plugins

    XMLWordPrintable

Details

    • 2.357

    Description

      None of the currently bundled jenkins-module packages actually look like they need to be modules: they do not appear to need to be loaded in the same class loader as jenkins-core.jar, nor to have extensions/services registered early in the startup sequence. As such, they could be made into regular plugins (hpi packaging), and the usual split-plugins.txt registry used to retain compatibility for existing plugins which happen to refer to their classes (InstanceIdentity and SshCommandFactory are the main examples).

      As an aside refiled as JENKINS-57023.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-70206 jenkins.security.Security218Test#jnlpSlave is flaky

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-64107 Convert SSHD module to a plugin

          • Major - Major loss of function.
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-57071 Cannot use Linux agent installer modules

          • Major - Major loss of function.
          • Resolved

          Task - A task that needs to be done. JENKINS-57023 Split external library functionality into its own plugin

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is blocking

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. JENKINS-64104 Upgrade and migrate to Apache Mina SSH 2.x

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • In Progress

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-68662 Instance identity plugin can't encode/decode PEM in a FIPS configured OS / host

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-57528 Jenkins in Docker does not install detached plugins when there is no UC data

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-41987 Cryptic error message when loading JnlpSlaveAgentProtocol4

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-44100 Detach Remoting protocol management logic in Jenkins core to a plugin

          • Major - Major loss of function.
          • Open
          links to

          Web Link CloudBees-internal issue

          Web Link instance-identity #17

          Web Link jenkins #3988

          Web Link jenkins #6585

          Web Link jep #326

          Web Link JEP-230

          Web Link slave-installer #5

          Web Link ssh-cli-auth #9

          Activity

            Ascending order - Click to sort in descending order
            View 10 older comments
            jglick Jesse Glick added a comment -

            Just now realized that the slave installers only work if the inbound agent is launched in “GUI” mode, which is only available when using javaws, which is semi-deprecated and might be dropped altogether if we decline to keep signing remoting.jar. (Anyway they are only useful if the user account launching the agent has administrator privileges to register a service.) So while slave-installer and its four implementations can still be trivially converted to plugins, we may decide to stop bundling them, meaning that we would be down to three detached plugins (instance-identity, ssh-cli-auth, sshd), which might ease some of the objections to this change.

            jglick Jesse Glick added a comment - Just now realized that the slave installers only work if the inbound agent is launched in “GUI” mode, which is only available when using javaws , which is semi-deprecated and might be dropped altogether if we decline to keep signing remoting.jar . (Anyway they are only useful if the user account launching the agent has administrator privileges to register a service.) So while slave-installer and its four implementations can still be trivially converted to plugins, we may decide to stop bundling them, meaning that we would be down to three detached plugins ( instance-identity , ssh-cli-auth , sshd ), which might ease some of the objections to this change.
            ifernandezcalvo Ivan Fernandez Calvo added a comment -

            jglickoleg_nenashev I recently started thinking to bump the Apache Mina to 2.5.x version on the SSHD module, doing it, I have found several works in progress related to this module, the bum of the library JENKINS-60902, and this one about converting the module in a plugin. After thinking deeply about it I think that we have to move it first to plugin and then bump the version of the library. So, If you do not have any objection, I'd like to take ownership of move SSHD module to a plugin, I have made one of those in the past wit the trilead-ssh2.

            ifernandezcalvo Ivan Fernandez Calvo added a comment - jglick oleg_nenashev I recently started thinking to bump the Apache Mina to 2.5.x version on the SSHD module, doing it, I have found several works in progress related to this module, the bum of the library JENKINS-60902 , and this one about converting the module in a plugin. After thinking deeply about it I think that we have to move it first to plugin and then bump the version of the library. So, If you do not have any objection, I'd like to take ownership of move SSHD module to a plugin, I have made one of those in the past wit the trilead-ssh2.
            jglick Jesse Glick added a comment - - edited

            I was actually thinking about resurrecting this effort and filing a JEP with the updated proposal. One change from the initial proposal would be to inline ssh-cli-auth into sshd. ifernandezcalvo Do you mind waiting a day or two for me to file a JEP draft so we have a baseline for discussion? It should be possible to separate the actual work and do it in stages, so it would be perfect if you wanted to handle the SSH-related portions, since you have the detailed knowledge of associated issues.

            jglick Jesse Glick added a comment - - edited I was actually thinking about resurrecting this effort and filing a JEP with the updated proposal. One change from the initial proposal would be to inline ssh-cli-auth into sshd . ifernandezcalvo Do you mind waiting a day or two for me to file a JEP draft so we have a baseline for discussion? It should be possible to separate the actual work and do it in stages, so it would be perfect if you wanted to handle the SSH-related portions, since you have the detailed knowledge of associated issues.
            ifernandezcalvo Ivan Fernandez Calvo added a comment -

            sure, there is no rush.

            ifernandezcalvo Ivan Fernandez Calvo added a comment - sure, there is no rush.
            jglick Jesse Glick added a comment -

            I filed jep #326 to both formalize this change and reflect changes to my original proposal.

            jglick Jesse Glick added a comment - I filed jep #326 to both formalize this change and reflect changes to my original proposal.

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: