-
Bug
-
Resolution: Fixed
-
Major
It is a follow-up to https://github.com/jenkinsci/jenkins/pull/2746
In Jenkins we call cleanup() handlers after destroying the WebAppMain context. At this point Jenkins is already semi-dead, hence we should proceed with the restart in any case even if the cleanup fails. Otherwise we may get a dead instance.
I am still not sure about LifeCycles, but Jenkins code reviewers approved it. Will monitor the related issues
Code changed in jenkins
User: Oleg Nenashev
Path:
core/src/main/java/hudson/WebAppMain.java
core/src/main/java/hudson/lifecycle/SolarisSMFLifecycle.java
core/src/main/java/hudson/lifecycle/UnixLifecycle.java
core/src/main/java/hudson/lifecycle/WindowsServiceLifecycle.java
http://jenkins-ci.org/commit/jenkins/4ab693846ca7a4aa112959a2e92688c3fb9122c3
Log:
Merge pull request #2746 from oleg-nenashev/bug/
JENKINS-32820[JENKINS-32820, JENKINS-42164] - Windows service restart does not retain the build queue
Compare: https://github.com/jenkinsci/jenkins/compare/1763e6400f56...4ab693846ca7