Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42194

SCMTrigger should not give a warning when used to suppress post-commit hooks

    XMLWordPrintable

Details

    Description

      The Poll SCM trigger has two purposes:

      1. Setting a cadence for polling SCM
      2. Declaring that post commit hooks should be ignored

      Currently if you want to ignore post commit hooks you are supposed to configure the trigger like so:

      Now the issue here is that we are displaying a warning for a desired configuration. This leads users to think that they are doing something wrong.

      As a consequence of this, we have had developers of other plugins add their own trigger implementations to control push trigger ignore behaviour (see GitHub plugin for an example)

      What we really want is that the field validation should state that empty polling is OK when ignoring triggers:

      But retain the field validation when either not ignoring hooks or ignoring hooks but invalid spec

      Attachments

        Issue Links

          links to

          Web Link PR#2758

          Activity

            Descending order - Click to sort in ascending order
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            core/src/main/java/hudson/triggers/SCMTrigger.java
            core/src/main/resources/hudson/triggers/SCMTrigger/config.jelly
            http://jenkins-ci.org/commit/jenkins/403b1ef6248e4c84fc6a6c19f9906aaf1cb9b461
            Log:
            [FIXED JENKINS-42194] Do not display a warning when ignoring post-commit hooks

            (cherry picked from commit d0d9216f4fba8337f853aadf9853fb8dcc5cb1cf)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/triggers/SCMTrigger.java core/src/main/resources/hudson/triggers/SCMTrigger/config.jelly http://jenkins-ci.org/commit/jenkins/403b1ef6248e4c84fc6a6c19f9906aaf1cb9b461 Log: [FIXED JENKINS-42194] Do not display a warning when ignoring post-commit hooks (cherry picked from commit d0d9216f4fba8337f853aadf9853fb8dcc5cb1cf)
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            core/src/main/java/hudson/triggers/SCMTrigger.java
            core/src/main/resources/hudson/triggers/Messages.properties
            http://jenkins-ci.org/commit/jenkins/7f42b5bbd31376fa52c1b3aeab15a3c3d3f9f238
            Log:
            JENKINS-42194 Code review reveals valid point, no schedules is not a warning

            (cherry picked from commit 5f5f88006958b1dbac6a8747dea62b8e338c2f7d)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/triggers/SCMTrigger.java core/src/main/resources/hudson/triggers/Messages.properties http://jenkins-ci.org/commit/jenkins/7f42b5bbd31376fa52c1b3aeab15a3c3d3f9f238 Log: JENKINS-42194 Code review reveals valid point, no schedules is not a warning (cherry picked from commit 5f5f88006958b1dbac6a8747dea62b8e338c2f7d)
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            core/src/main/java/hudson/triggers/SCMTrigger.java
            core/src/main/resources/hudson/triggers/Messages.properties
            core/src/main/resources/hudson/triggers/SCMTrigger/config.jelly
            http://jenkins-ci.org/commit/jenkins/d0d9216f4fba8337f853aadf9853fb8dcc5cb1cf
            Log:
            [FIXED JENKINS-42194] Do not display a warning when ignoring post-commit hooks

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/triggers/SCMTrigger.java core/src/main/resources/hudson/triggers/Messages.properties core/src/main/resources/hudson/triggers/SCMTrigger/config.jelly http://jenkins-ci.org/commit/jenkins/d0d9216f4fba8337f853aadf9853fb8dcc5cb1cf Log: [FIXED JENKINS-42194] Do not display a warning when ignoring post-commit hooks
            stephenconnolly Stephen Connolly added a comment -

            Thinking on this more, an empty schedules should not be a warning for Poll SCM ever, we should explain that post commit hooks may contribute or not

            stephenconnolly Stephen Connolly added a comment - Thinking on this more, an empty schedules should not be a warning for Poll SCM ever , we should explain that post commit hooks may contribute or not

            People

              stephenconnolly Stephen Connolly
              stephenconnolly Stephen Connolly
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: