Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42194

SCMTrigger should not give a warning when used to suppress post-commit hooks

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The Poll SCM trigger has two purposes:

      1. Setting a cadence for polling SCM
      2. Declaring that post commit hooks should be ignored

      Currently if you want to ignore post commit hooks you are supposed to configure the trigger like so:

      Now the issue here is that we are displaying a warning for a desired configuration. This leads users to think that they are doing something wrong.

      As a consequence of this, we have had developers of other plugins add their own trigger implementations to control push trigger ignore behaviour (see GitHub plugin for an example)

      What we really want is that the field validation should state that empty polling is OK when ignoring triggers:

      But retain the field validation when either not ignoring hooks or ignoring hooks but invalid spec

        Attachments

          Issue Links

            Activity

            stephenconnolly Stephen Connolly created issue -
            stephenconnolly Stephen Connolly made changes -
            Field Original Value New Value
            Status Open [ 1 ] In Progress [ 3 ]
            stephenconnolly Stephen Connolly made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            stephenconnolly Stephen Connolly made changes -
            Remote Link This issue links to "PR#2758 (Web Link)" [ 15467 ]
            danielbeck Daniel Beck made changes -
            Labels lts-candidate
            danielbeck Daniel Beck made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            olivergondza Oliver Gond┼ża made changes -
            Labels lts-candidate 2.46.2-fixed
            stephenconnolly Stephen Connolly made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              Assignee:
              stephenconnolly Stephen Connolly
              Reporter:
              stephenconnolly Stephen Connolly
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: