• 1.0

      Atm, the SSE client executes an immediate ping request to the server on receipt of an SSE channel error. This is too eager. We should wait a few seconds before performing the ping, giving the SSE connection a chance to see if it can "fix" itself (e.g. during a reconnect).

      I was sure this was how it was working already. Maybe I unwittingly introduced this at some point.

          [JENKINS-42196] Eliminate overly-eager SSE ping request

          Tom FENNELLY added a comment -

          Noticed this while investigating JENKINS-42137.

          Tom FENNELLY added a comment - Noticed this while investigating JENKINS-42137 .

          Code changed in jenkins
          User: Tom Fennelly
          Path:
          package.json
          src/main/js/SSEConnection.js
          http://jenkins-ci.org/commit/sse-gateway-plugin/c225bf976b0b0b42aadea1135eef7392e8dcd721
          Log:
          [FIX JENKINS-42196] Eliminate overly-eager SSE ping request (#18)

          • Only ping after giving the connection a chance to heal itself

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Tom Fennelly Path: package.json src/main/js/SSEConnection.js http://jenkins-ci.org/commit/sse-gateway-plugin/c225bf976b0b0b42aadea1135eef7392e8dcd721 Log: [FIX JENKINS-42196] Eliminate overly-eager SSE ping request (#18) Only ping after giving the connection a chance to heal itself 0.0.19-tf- JENKINS-42196 -1

            tfennelly Tom FENNELLY
            tfennelly Tom FENNELLY
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: