Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42235

Attempting to create a root/unfiltered log recorder with level 'ALL' should display a warning

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • None
    • 2.344

      As I learned the hard way, the Jenkins log recorder UI makes it easy for you to accidentally create an unfiltered recorder with a log level of 'ALL' (because that is the default level), and this will easily overwhelm and take down Jenkins if it is under normal load. In my case the only way to recover was to find the log recorder config XML file on the filesystem, move it aside, and restart Jenkins. This caused an unpleasant 25 minute production outage for us.

      I would propose that if the user attempts to create an empty recorder at level ALL we should throw a warning dialog, explaining that this configuration can be dangerous, and give them the option to back out.

      Alternatively, maybe the default level should be SEVERE rather than ALL, so that if you accidentally create an unfiltered recorder it won't log much.

      danielbeck do you want to comment on this? I can make an attempt at implementation if you think the logic is sound.

          [JENKINS-42235] Attempting to create a root/unfiltered log recorder with level 'ALL' should display a warning

          Owen Mehegan created issue -
          Owen Mehegan made changes -
          Description Original: As I learned the hard way, the Jenkins log recorder UI makes it easy for you to accidentally create an unfiltered recorder with a log level of 'ALL' (because that is the default level), and this will easily overwhelm and take down Jenkins if it is under normal load. In my case the only way to recover was to find the log recorder config XML file on the filesystem, move it aside, and restart Jenkins. This caused an unpleasant 25 minute production outage for us.

          I would propose that if the user attempts to create an empty recorder at level ALL we should throw a warning dialog, explaining that this configuration can be dangerous, and give them the option to back out.

          Alternatively, maybe the default level should be SEVERE rather than ALL, so that if you accidentally create an unfiltered recorder it won't log much.

          [~danielbeck] you want to comment on this? I can make an attempt at implementation if you think the logic is sound.
          New: As I learned the hard way, the Jenkins log recorder UI makes it easy for you to accidentally create an unfiltered recorder with a log level of 'ALL' (because that is the default level), and this will easily overwhelm and take down Jenkins if it is under normal load. In my case the only way to recover was to find the log recorder config XML file on the filesystem, move it aside, and restart Jenkins. This caused an unpleasant 25 minute production outage for us.

          I would propose that if the user attempts to create an empty recorder at level ALL we should throw a warning dialog, explaining that this configuration can be dangerous, and give them the option to back out.

          Alternatively, maybe the default level should be SEVERE rather than ALL, so that if you accidentally create an unfiltered recorder it won't log much.

          [~danielbeck] do you want to comment on this? I can make an attempt at implementation if you think the logic is sound.
          Allan BURDAJEWICZ made changes -
          Link New: This issue relates to JENKINS-62472 [ JENKINS-62472 ]
          Basil Crow made changes -
          Link New: This issue relates to JENKINS-68284 [ JENKINS-68284 ]
          Basil Crow made changes -
          Released As New: 2.344
          Assignee New: Tim Jacomb [ timja ]
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Fixed but Unreleased [ 10203 ]
          Basil Crow made changes -
          Status Original: Fixed but Unreleased [ 10203 ] New: Resolved [ 5 ]

            timja Tim Jacomb
            owenmehegan Owen Mehegan
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: