Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42594

Merged pull requests should be differentiated on Pull Request tab

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Major Major
    • blueocean-plugin
    • None

      PRs that have been merged in Github (organisation view) are rendered as as strikethrough it classic view, however in BO they are rendered the same as every other PR.

      Ideally they should be rendered differently (and/or have an option to show/hide them)

          [JENKINS-42594] Merged pull requests should be differentiated on Pull Request tab

          James Dumay added a comment -

          teilo thanks for bringing this up. What if we didn't show merged PRs? What use case would that be removing?

          James Dumay added a comment - teilo thanks for bringing this up. What if we didn't show merged PRs? What use case would that be removing?

          James Dumay added a comment -

          stephenconnolly how would we differentiate in the API between merged and non-merged PRs?

          James Dumay added a comment - stephenconnolly how would we differentiate in the API between merged and non-merged PRs?

          James Nord added a comment -

          jamesdumay Not sure what the UC is for still showing them, I'm sure someone has one, I guess if you wanted to go an look at it after it was merged but not deleted then if the merged build failed you may want to check the PR result for comparison...

          James Nord added a comment - jamesdumay Not sure what the UC is for still showing them, I'm sure someone has one, I guess if you wanted to go an look at it after it was merged but not deleted then if the merged build failed you may want to check the PR result for comparison...

          James Dumay added a comment -

          Gotcha. Thanks teilo!

          James Dumay added a comment - Gotcha. Thanks teilo !

          A branch is strike-through if the branch is a dead branch. This means that the branch no longer exists in the backing SCM (i.e. the branch was deleted or the PR was merged / abandoned - you cannot differentiate those two)

           

          If Branch instanceof Branch.Dead then it is a dead branch

           

          HTH

          Stephen Connolly added a comment - A branch is strike-through if the branch is a dead branch. This means that the branch no longer exists in the backing SCM (i.e. the branch was deleted or the PR was merged / abandoned - you cannot differentiate those two)   If Branch instanceof Branch.Dead then it is a dead branch   HTH

          James Dumay added a comment -

          James Dumay added a comment - Thanks stephenconnolly

            Unassigned Unassigned
            teilo James Nord
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: