Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42626

«by build results» shortcut link cannot be added

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I tried to change the failed shortcut link to select both failed and unstable builds but it did not work (might be another bug).

      So I deleted this shortcut link and then wanted to add separate ones for failed and unstable, but selecting «Add shortcut link>By build result» does nothing.

      Adding links by combination filters works fine.

        Attachments

          Activity

          Hide
          ikedam ikedam added a comment -

          This is caused for the following exception:

          Caused by: java.lang.NullPointerException: Cannot get property 'resultsToCheck' on null object
                  at org.codehaus.groovy.runtime.NullObject.getProperty(NullObject.java:60)
                  at org.codehaus.groovy.runtime.InvokerHelper.getProperty(InvokerHelper.java:172)
                  at org.codehaus.groovy.runtime.callsite.NullCallSite.getProperty(NullCallSite.java:47)
                  at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callGetProperty(AbstractCallSite.java:296)
                  at config$_run_closure3.doCall(config.groovy:39)
                  at config$_run_closure3.doCall(config.groovy)
                  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
                  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
                  at java.lang.reflect.Method.invoke(Method.java:498)
                  at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
                  at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
                  at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:294)
                  at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1024)
                  at groovy.lang.Closure.call(Closure.java:414)
                  at groovy.lang.Closure.call(Closure.java:408)
                  at org.kohsuke.stapler.jelly.groovy.JellyBuilder$1.run(JellyBuilder.java:264)
                  at org.kohsuke.stapler.jelly.CallTagLibScript$1.run(CallTagLibScript.java:99)
                  at org.apache.commons.jelly.tags.define.InvokeBodyTag.doTag(InvokeBodyTag.java:91)
                  at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:269)
                  ... 99 more
          

          (config.groovy is https://github.com/jenkinsci/matrix-combinations-plugin/blob/matrix-combinations-parameter-1.1.0/src/main/resources/hudson/plugins/matrix_configuration_parameter/shortcut/ResultShortcut/config.groovy )

          Show
          ikedam ikedam added a comment - This is caused for the following exception: Caused by: java.lang.NullPointerException: Cannot get property 'resultsToCheck' on null object at org.codehaus.groovy.runtime.NullObject.getProperty(NullObject.java:60) at org.codehaus.groovy.runtime.InvokerHelper.getProperty(InvokerHelper.java:172) at org.codehaus.groovy.runtime.callsite.NullCallSite.getProperty(NullCallSite.java:47) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callGetProperty(AbstractCallSite.java:296) at config$_run_closure3.doCall(config.groovy:39) at config$_run_closure3.doCall(config.groovy) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93) at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325) at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:294) at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1024) at groovy.lang.Closure.call(Closure.java:414) at groovy.lang.Closure.call(Closure.java:408) at org.kohsuke.stapler.jelly.groovy.JellyBuilder$1.run(JellyBuilder.java:264) at org.kohsuke.stapler.jelly.CallTagLibScript$1.run(CallTagLibScript.java:99) at org.apache.commons.jelly.tags.define.InvokeBodyTag.doTag(InvokeBodyTag.java:91) at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:269) ... 99 more (config.groovy is https://github.com/jenkinsci/matrix-combinations-plugin/blob/matrix-combinations-parameter-1.1.0/src/main/resources/hudson/plugins/matrix_configuration_parameter/shortcut/ResultShortcut/config.groovy )
          Show
          ikedam ikedam added a comment - https://github.com/jenkinsci/matrix-combinations-plugin/pull/20
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/resources/hudson/plugins/matrix_configuration_parameter/shortcut/ResultShortcut/config.groovy
          http://jenkins-ci.org/commit/matrix-combinations-plugin/b5defc02dfb7ad6b8b3d098c0446fe716d1dbf6f
          Log:
          [FIXED JENKINS-42626] Avoid NPE when adding "By build result"

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/resources/hudson/plugins/matrix_configuration_parameter/shortcut/ResultShortcut/config.groovy http://jenkins-ci.org/commit/matrix-combinations-plugin/b5defc02dfb7ad6b8b3d098c0446fe716d1dbf6f Log: [FIXED JENKINS-42626] Avoid NPE when adding "By build result"
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/resources/hudson/plugins/matrix_configuration_parameter/shortcut/ResultShortcut/config.groovy
          http://jenkins-ci.org/commit/matrix-combinations-plugin/1f2359f2b40a22e6e36ed01df9fbab75faea8030
          Log:
          Merge pull request #20 from ikedam/feature/JENKINS-42626_NpeOnByBuildResults

          [FIXED JENKINS-42626] Avoid NPE when adding "By build result"

          Compare: https://github.com/jenkinsci/matrix-combinations-plugin/compare/e823701d5cb0...1f2359f2b40a

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/resources/hudson/plugins/matrix_configuration_parameter/shortcut/ResultShortcut/config.groovy http://jenkins-ci.org/commit/matrix-combinations-plugin/1f2359f2b40a22e6e36ed01df9fbab75faea8030 Log: Merge pull request #20 from ikedam/feature/ JENKINS-42626 _NpeOnByBuildResults [FIXED JENKINS-42626] Avoid NPE when adding "By build result" Compare: https://github.com/jenkinsci/matrix-combinations-plugin/compare/e823701d5cb0...1f2359f2b40a
          Hide
          ikedam ikedam added a comment -

          Fixed in matrix-combinations-parameter-1.1.1.
          It will be available in the update center in a day.
          Please try that.

          Show
          ikedam ikedam added a comment - Fixed in matrix-combinations-parameter-1.1.1. It will be available in the update center in a day. Please try that.
          Hide
          mcmic Côme Chilliet added a comment -

          I can add shortcut links now but they still do not work they check either everything or nothing.

          Show
          mcmic Côme Chilliet added a comment - I can add shortcut links now but they still do not work they check either everything or nothing.
          Hide
          ikedam ikedam added a comment -

          > they still do not work they check either everything or nothing.

          You may describe more details about the problem.
          It looks work well in my environment, Jenkins 2.32.3 + matrix-combinations-parameter-1.1.1 + Firefox 52.0.2.

          Show
          ikedam ikedam added a comment - > they still do not work they check either everything or nothing. You may describe more details about the problem. It looks work well in my environment, Jenkins 2.32.3 + matrix-combinations-parameter-1.1.1 + Firefox 52.0.2.
          Hide
          mcmic Côme Chilliet added a comment -

          Jenkins 2.55 + matrix-combinations-parameter-1.1.1 + Firefox 45.8

          All and None shortcuts works fine.

          All other shortcuts behave like «All». (Success, Failure, and the ones I add myself, even one with groovy filter)

          Show
          mcmic Côme Chilliet added a comment - Jenkins 2.55 + matrix-combinations-parameter-1.1.1 + Firefox 45.8 All and None shortcuts works fine. All other shortcuts behave like «All». (Success, Failure, and the ones I add myself, even one with groovy filter)
          Hide
          ikedam ikedam added a comment -

          It sounds strange that only "All" and "None" work fine and others don't as all shortcuts work with the same mechanism.
          Would you create a new ticket and describe detailed steps to reproduce the issue? I especially want to know wheter it happens with specific axes definitions or specific build status.

          Show
          ikedam ikedam added a comment - It sounds strange that only "All" and "None" work fine and others don't as all shortcuts work with the same mechanism. Would you create a new ticket and describe detailed steps to reproduce the issue? I especially want to know wheter it happens with specific axes definitions or specific build status.
          Show
          mcmic Côme Chilliet added a comment - Opened https://issues.jenkins-ci.org/browse/JENKINS-43853

            People

            Assignee:
            mcmic Côme Chilliet
            Reporter:
            mcmic Côme Chilliet
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: