Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42719

Bug fixes / enhancements to Dropdown

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • blueocean-plugin
    • None
    • Blue Ocean 1.0-rc3

      While working JENKINS-42120 some bugs in the JDL Dropdown became evident:

      1. Adjust the height of dropdown to match that of standard button.
      2. Prevent NPE if "data" prop is null/undefined
      3. Need better UX if the "data" prop is an empty array. Right now an empty menu opens which looks odd. Should either prevent the menu from displaying, or perhaps display it with some kind of "no options" menu.

          [JENKINS-42719] Bug fixes / enhancements to Dropdown

          Cliff Meyers added a comment -

          PR: https://github.com/jenkinsci/jenkins-design-language/pull/157

          Cliff Meyers added a comment - PR: https://github.com/jenkinsci/jenkins-design-language/pull/157

          Cliff Meyers added a comment -

          Decided in PR to defer the "programmatic selection" to avoid API's that we might deprecate later, or breaking current backward compat. Will address in a series of broader changes to JDL down the road. For now, reaching into the state of the Dropdown works. A hack, but used only in one place today.

          Cliff Meyers added a comment - Decided in PR to defer the "programmatic selection" to avoid API's that we might deprecate later, or breaking current backward compat. Will address in a series of broader changes to JDL down the road. For now, reaching into the state of the Dropdown works. A hack, but used only in one place today.

            cliffmeyers Cliff Meyers
            cliffmeyers Cliff Meyers
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: