Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42735

Error when saving branch that has / in the name

XMLWordPrintable

    • Blue Ocean 1.0-rc3

      If you fork and add a github pipeline such as: 

       

      https://github.com/i386/app-store-demo

       

      And open a branch that is something like "foo/bar", edit the pipeline, when you save it you will see: 

       

      However, it did actually save to github, but it wasn't able to find the pipeline to trigger a scan/build for and then redirect to. This must be one of those encoding problems

       

      For other branch names, it works as advertised. 

        1. Screen Shot 2017-03-14 at 12.35.50 pm.png
          Screen Shot 2017-03-14 at 12.35.50 pm.png
          28 kB

          [JENKINS-42735] Error when saving branch that has / in the name

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Keith Zantow
          Path:
          pom.xml
          src/main/js/EditorPage.jsx
          src/main/js/EditorRoutes.jsx
          src/main/js/PipelineEditorLink.jsx
          src/main/js/components/editor/CopyPastePipelineDialog.jsx
          src/main/js/components/editor/EditorPage.jsx
          src/main/js/services/PipelineSyntaxConverter.js
          src/main/js/services/Security.js
          src/main/less/editor.less
          http://jenkins-ci.org/commit/blueocean-pipeline-editor-plugin/43c191341e3836e741425085d76784d08e34b327
          Log:
          Fix some misc. issues discovered in rc1 (#33)

          • JENKINS-42788 - hide editor links when no create permission
          • JENKINS-42790 - don't show the toast for a new pipeline
          • JENKINS-42647 - don't show Github JSON blob
          • JENKINS-42735 - encoding issue with branch names when save/run
          • JENKINS-42649 - ctrl/cmd + s to open the load/save dialog
          • Route tweaks to get to pipeline editor
          • Bump blueocean version to 1.0.0-rc1
          • JENKINS-42789 - error copy tweaks

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Keith Zantow Path: pom.xml src/main/js/EditorPage.jsx src/main/js/EditorRoutes.jsx src/main/js/PipelineEditorLink.jsx src/main/js/components/editor/CopyPastePipelineDialog.jsx src/main/js/components/editor/EditorPage.jsx src/main/js/services/PipelineSyntaxConverter.js src/main/js/services/Security.js src/main/less/editor.less http://jenkins-ci.org/commit/blueocean-pipeline-editor-plugin/43c191341e3836e741425085d76784d08e34b327 Log: Fix some misc. issues discovered in rc1 (#33) JENKINS-42788 - hide editor links when no create permission JENKINS-42790 - don't show the toast for a new pipeline JENKINS-42647 - don't show Github JSON blob JENKINS-42735 - encoding issue with branch names when save/run JENKINS-42649 - ctrl/cmd + s to open the load/save dialog Route tweaks to get to pipeline editor Bump blueocean version to 1.0.0-rc1 JENKINS-42789 - error copy tweaks

            kzantow Keith Zantow
            michaelneale Michael Neale
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: