-
Bug
-
Resolution: Fixed
-
Minor
-
None
Currently the code implements the macro engine on its own, but then it takes the config file from the core, which may actually change at any moment. A Longer-term fix is JENKINS-42743, but now it makes sense to have a hotfix like a local copy of the file.
- is related to
-
JENKINS-42743 Windows Slaves plugin should use API of the Windows Agent Installer Module
-
- Closed
-
-
JENKINS-42724 Windows Slaves Plugin: agent is not starting after upgrade to Jenkins 2.50
-
- Closed
-
- links to
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java
src/main/resources/hudson/os/windows/configsamples/jenkins-slave.xml
src/test/java/hudson/os/windows/ManagedWindowsServiceLauncherTest.java
http://jenkins-ci.org/commit/windows-slaves-plugin/0872fc38409a7efe05f239650e944aef4e174456
Log:
JENKINS-42746- Make the plugin independent from the XML sample in the coreIn Jenkins 2.50 we have got
JENKINS-42724, which has been caused by the usage of the old resource file located within the Jenkins core.It is likely a leftover from the migration of the windows-slaves-installer module.
Since the Windows Slaves plugin has its internal macro resolution logic, the sample should be also inside plugin. A longer-term fix is to make the plugin depent on the Windows Agent Installer module