Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42820

Regression in analysis-core:1.82 when browsing warnings

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • None
    • Jenkins ver. 2.32.3
      RHEL 6.4
      Java 1.8.0_60-b27
      static analysis_core 1.82

      When browsing warnings some of the links appear to be broken since version 1.82 of the analysis-core plugin.

      I tried reverting to analysis-core version 1.81 and everything is working correctly so there has been a regression here.

      To give you an example, when I browse to:

      http://jenkins/job/jobname/125/warnings2Result/

      There is a link shown on the "Types" tab to:

      http://jenkins/job/jobname/125/warnings2Result/category.-52074025/

      but following that link redirects back to:

      http://jenkins/job/jobname/125/warnings2Result/

      I wonder if it is related to the following bug: -JENKINS-37195-

       

       

          [JENKINS-42820] Regression in analysis-core:1.82 when browsing warnings

          in 4.58 the filter on the "Types" tab works correctly and shows the correct result.
          The version of both "warnings-plugin" and "static-analysis-core" are different so I'm not sure which plugin causes the problem.

          Is there some way I could enable some extra debugging in order to get to the bottom of the issue?

          Andrew Barnish added a comment - in 4.58 the filter on the "Types" tab works correctly and shows the correct result. The version of both "warnings-plugin" and "static-analysis-core" are different so I'm not sure which plugin causes the problem. Is there some way I could enable some extra debugging in order to get to the bottom of the issue?

          Ulli Hafner added a comment - - edited

          Fix for JENKINS-37195 is only in analysis-core: https://github.com/jenkinsci/analysis-core-plugin/commit/1dcfdc5df42790f55a51a4592923b65916385b0b
          So if you downgrade the warnings plugin (without altering analysis-core) and it works afterwards then this must be something different. Is there a reason that you did not try the latest release 4.60? Which analysis-core do you use?

          In 4.59 the default category has been changed to '-'. Maybe this is a problem with old builds? Happens the problem you are describing on a build that you started with the new plugin? Which types in the tab Types do you have?

          Ulli Hafner added a comment - - edited Fix for JENKINS-37195 is only in analysis-core: https://github.com/jenkinsci/analysis-core-plugin/commit/1dcfdc5df42790f55a51a4592923b65916385b0b So if you downgrade the warnings plugin (without altering analysis-core) and it works afterwards then this must be something different. Is there a reason that you did not try the latest release 4.60? Which analysis-core do you use? In 4.59 the default category has been changed to '-'. Maybe this is a problem with old builds? Happens the problem you are describing on a build that you started with the new plugin? Which types in the tab Types do you have?

          I was using the very latest release of both warnings (4.60) and analysis-core(1.82), but I noticed the original behavior was broken so I reverted to very old releases of both warnings and analysis-core in order to see where the problematic code change occurred.

          I then moved forward through the warning releases until the regression occurred. I noticed this happened when going from warnings:4.58/analysis-core:1.80 (working) to warnings:4.59/analysis-core:1.82 (not working)

          Perhaps the problem is coming from analysis-core. I don't think I can run the latest warnings plugin with analysis-core 1.80.

          Andrew Barnish added a comment - I was using the very latest release of both warnings (4.60) and analysis-core(1.82), but I noticed the original behavior was broken so I reverted to very old releases of both warnings and analysis-core in order to see where the problematic code change occurred. I then moved forward through the warning releases until the regression occurred. I noticed this happened when going from warnings:4.58/analysis-core:1.80 (working) to warnings:4.59/analysis-core:1.82 (not working) Perhaps the problem is coming from analysis-core. I don't think I can run the latest warnings plugin with analysis-core 1.80.

          Ulli Hafner added a comment -

          For which type names does the link not work?

          Is the build where the links do not work created with warnings:4.59/analysis-core:1.82?

          Ulli Hafner added a comment - For which type names does the link not work? Is the build where the links do not work created with warnings:4.59/analysis-core:1.82?

          I upgraded to warnings 4.58 and analysis-core 1.81 and the links are still working properly, so I suspect the regression is in analysis-core 1.82. Unfortunately I cannot try warnings 4.60 with that version of analysis-core as the minimum requirement is 1.82

          The type names are like: SGDC_waive27 or WRN_47

          Yes, it definitely is still broken even if the build is done with the latest release: warnings:4.60/analysis-core:1.82

          Can you create some kind of debug build or give me a hint where I can look for the problem?

          Andrew Barnish added a comment - I upgraded to warnings 4.58 and analysis-core 1.81 and the links are still working properly, so I suspect the regression is in analysis-core 1.82. Unfortunately I cannot try warnings 4.60 with that version of analysis-core as the minimum requirement is 1.82 The type names are like: SGDC_waive27 or WRN_47 Yes, it definitely is still broken even if the build is done with the latest release: warnings:4.60/analysis-core:1.82 Can you create some kind of debug build or give me a hint where I can look for the problem?

          Also warnings 4.58 and analysis-core 1.82 is not working.

          Andrew Barnish added a comment - Also warnings 4.58 and analysis-core 1.82 is not working.

          Ulli Hafner added a comment -

          I spotted the problem! I should have seen this earlier in our conversion when you talked about the type and I about the category. The link needs to be have the 'type' prefix and not 'category'!

          Ulli Hafner added a comment - I spotted the problem! I should have seen this earlier in our conversion when you talked about the type and I about the category. The link needs to be have the 'type' prefix and not 'category'!

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/resources/hudson/plugins/analysis/views/TabDetail/types.jelly
          http://jenkins-ci.org/commit/analysis-core-plugin/894ca33237d6036c624a51a2d36d4e04c4cde366
          Log:
          [FIXED JENKINS-42820] Fixed navigation into warnings by type.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/resources/hudson/plugins/analysis/views/TabDetail/types.jelly http://jenkins-ci.org/commit/analysis-core-plugin/894ca33237d6036c624a51a2d36d4e04c4cde366 Log: [FIXED JENKINS-42820] Fixed navigation into warnings by type.

          Andrew Barnish added a comment - - edited

          I tested the snapshot build 1.83-SNAPSHOT on our jenkins server and it solved the issue.

          Thanks for the very quick fix.

          Andrew Barnish added a comment - - edited I tested the snapshot build 1.83-SNAPSHOT  on our jenkins server and it solved the issue. Thanks for the very quick fix.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          analysis-core
          http://jenkins-ci.org/commit/analysis-suite-plugin/8563f9d921d4c3a691c310dabc3525990cb0549c
          Log:
          [FIXED JENKINS-42820] Fixed navigation into warnings by type.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: analysis-core http://jenkins-ci.org/commit/analysis-suite-plugin/8563f9d921d4c3a691c310dabc3525990cb0549c Log: [FIXED JENKINS-42820] Fixed navigation into warnings by type.

            drulli Ulli Hafner
            barnish Andrew Barnish
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: