Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42875

Durable Task 1.13 breaks env vars expressions contributed by EnvInject

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Thanks to the magic in the code, it appears EnvInject can contribute env vars to script steps in Pipeline. However, Durable Task 1.13 breaks some use-cases like nested variables (e.g. "MYVAR=$MYVAR:123" see the changelog).

      • EnvInject really injects job properties in this case using some non-trivial logic. I didn't notice that routine during the code review
      • Upgrade to Durable task 1.13 breaks the use-case
      • Upgrade to "Pipeline Nodes and Processes Plugin" 2.10 does not resolve the issue

      Though EnvInject does not support Pipeline, the root cause of this issue needs to be investigated and maybe fixed. Likely the fix should be applied on the EnvInject side according to my initial investigation.

        Attachments

          Issue Links

            Activity

            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Actually even more primitive cases like "MYVAR=var-$VAR" do not work anymore

            Show
            oleg_nenashev Oleg Nenashev added a comment - Actually even more primitive cases like "MYVAR=var-$VAR" do not work anymore
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Needs a redesign to work properly with the recent DurableTask. I consider JENKINS-44521 as a possible solution.

            Show
            oleg_nenashev Oleg Nenashev added a comment - Needs a redesign to work properly with the recent DurableTask. I consider  JENKINS-44521  as a possible solution.
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            No response from new maintainers, Jesse Glick was against marking the 1.13 change as incompatible.
            I have no interest to work on that, so unassigning myself

            Show
            oleg_nenashev Oleg Nenashev added a comment - No response from new maintainers, Jesse Glick was against marking the 1.13 change as incompatible. I have no interest to work on that, so unassigning myself

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              oleg_nenashev Oleg Nenashev
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated: