Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42924

Favourite pipelines working oddly when there is no default branch to favourite

    XMLWordPrintable

Details

    Description

      If favouriting fails the state of the favourite should not be favourited.

      Steps to reproduce (see video with reproducible steps):

      • Go to /blue
      • Star the hudson pipeline (or a pipeline that has no master to favorite) ‚Üí you will get an error saying that there is an error starring this pipeline because there is no master. But the pipeline is starred when it shouldn't
      • Then star another pipeline successfully. The pipeline before gets unstarred
      • Refreshing the screen will show the failed favourite as unfavourited

      Attachments

        Issue Links

          Activity

            cliffmeyers Cliff Meyers added a comment -

            jamesdumay I recall this default branch issue being discussed quite a long ways back - perhaps there is another related ticket as well?

            In the event there's an error, should we display a friendly error message and ensure the favorite star isn't shaded in?

            cliffmeyers Cliff Meyers added a comment - jamesdumay I recall this default branch issue being discussed quite a long ways back - perhaps there is another related ticket as well? In the event there's an error, should we display a friendly error message and ensure the favorite star isn't shaded in?
            cliffmeyers Cliff Meyers added a comment - - edited

            The error handling won't be too difficult here, but we probably need to give some additional feedback that an error occurred? Clicking the star and having it do nothing will just lead to confusion. Should we display some kind of error toast?

            cliffmeyers Cliff Meyers added a comment - - edited The error handling won't be too difficult here, but we probably need to give some additional feedback that an error occurred? Clicking the star and having it do nothing will just lead to confusion. Should we display some kind of error toast?
            angwonson Chris added a comment -

            I got this error today. Github (and 'git init' I think) switching to "main" vs "master". Something to consider.

            angwonson Chris added a comment - I got this error today. Github (and 'git init' I think) switching to "main" vs "master". Something to consider.
            ssbarnea Sorin Sbarnea added a comment -

            With almost everyone renaming master to main, this bug becomes from just an annoyance for a corner case a major issue, breaking favorite feature for most users.

            ssbarnea Sorin Sbarnea added a comment - With almost everyone renaming master to main, this bug becomes from just an annoyance for a corner case a major issue, breaking favorite feature for most users.

            People

              Unassigned Unassigned
              vilacides Isa Vilacides
              Votes:
              3 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated: