Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42960

Case insensitive search in fixed sets doesn't work in some cases

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None
    • Jenkins 2.50

      Case insensitive search in fixed sets doesn't work due to wrong comparison in code if the result to filter needs to be lower cased.

          [JENKINS-42960] Case insensitive search in fixed sets doesn't work in some cases

          Marcin Zajączkowski added a comment - Will be fixed in https://github.com/jenkinsci/jenkins/pull/2801 .

          Code changed in jenkins
          User: Marcin Zajączkowski
          Path:
          core/src/main/java/hudson/search/FixedSet.java
          core/src/main/java/hudson/search/UserSearchProperty.java
          core/src/test/java/hudson/model/ViewTest.java
          core/src/test/java/jenkins/widgets/HistoryPageFilterTest.java
          test/src/test/java/jenkins/widgets/HistoryPageFilterCaseSensitiveSearchTest.java
          test/src/test/java/jenkins/widgets/HistoryPageFilterInsensitiveSearchTest.java
          http://jenkins-ci.org/commit/jenkins/b831acd9854b525d680ca72fd218c848121b9d3f
          Log:
          JENKINS-42645 Case insensitive search by default for new and anonymous users (#2801)

          String.equalsIgnoreCase is safer than toLowerCase when non English
          locales are used.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Marcin Zajączkowski Path: core/src/main/java/hudson/search/FixedSet.java core/src/main/java/hudson/search/UserSearchProperty.java core/src/test/java/hudson/model/ViewTest.java core/src/test/java/jenkins/widgets/HistoryPageFilterTest.java test/src/test/java/jenkins/widgets/HistoryPageFilterCaseSensitiveSearchTest.java test/src/test/java/jenkins/widgets/HistoryPageFilterInsensitiveSearchTest.java http://jenkins-ci.org/commit/jenkins/b831acd9854b525d680ca72fd218c848121b9d3f Log: JENKINS-42645 Case insensitive search by default for new and anonymous users (#2801) JENKINS-42645 Case insensitive search by default JENKINS-42960 Search in FixedSet more locale friendly String.equalsIgnoreCase is safer than toLowerCase when non English locales are used. JENKINS-42645 Review remarks

            emszpak Marcin Zajączkowski
            emszpak Marcin Zajączkowski
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: